Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and verify pointseries #28946

Closed
w33ble opened this issue Jan 17, 2019 · 6 comments
Closed

Update and verify pointseries #28946

w33ble opened this issue Jan 17, 2019 · 6 comments
Labels
chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@w33ble
Copy link
Contributor

w33ble commented Jan 17, 2019

Kibana version: 6.6.1+

Describe the chore:

As noted in the comments on #28872, the pointseries function contains some legacy output and doesn't do any validation.

  • Remove role and expression from pointseries output (neither are used anywhere)
  • Add a validate check on the pointseries type
@w33ble w33ble added chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jan 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@w33ble w33ble mentioned this issue Jan 17, 2019
Merged
@cqliu1 cqliu1 added the loe:medium Medium Level of Effort label Mar 15, 2019
@clintandrewhall clintandrewhall added Team:AppArch and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jul 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@clintandrewhall
Copy link
Contributor

This was completed with one of my PRs before pointseries was ultimately moved to the Expressions plugin. I don't think this task is relevant any longer, but if it is, I'm assigning it to the Expressions team before closing it.

cc: @lukeelmers @ppisljar

@lukeelmers
Copy link
Member

Reopening -- AFAICT these tasks have not been done (looks like role and expression are still in the pointseries column output, and there is not yet a validate function on the pointseries type).

@lukeelmers lukeelmers reopened this Aug 3, 2020
@lukeelmers lukeelmers added technical debt Improvement of the software architecture and operational architecture Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Aug 3, 2020
@clintandrewhall
Copy link
Contributor

@lukeelmers My mistake... I was looking at role and expression in the function definition back in 6.x, not the output.

Thanks for looking at it and reopening.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort and removed loe:medium Medium Level of Effort labels Apr 20, 2021
@ppisljar ppisljar added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:AppServices labels Apr 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@petrklapka petrklapka added the 1 label May 10, 2021
@ppisljar ppisljar closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@clintandrewhall @w33ble @lukeelmers @cqliu1 @ppisljar @elasticmachine @petrklapka