Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated notice text to banner #50245

Closed
alexfrancoeur opened this issue Nov 12, 2019 · 8 comments · Fixed by #50403
Closed

Add updated notice text to banner #50245

alexfrancoeur opened this issue Nov 12, 2019 · 8 comments · Fixed by #50403
Assignees

Comments

@alexfrancoeur
Copy link

alexfrancoeur commented Nov 12, 2019

Related to #49644. We have some updated text we can apply to the banner. ]

Help us improve the Elastic Stack
Want to help us improve the Elastic Stack? Data usage collection is currently disabled. Enabling data usage collection helps us manage and improve our products and services. See our [Privacy Statement] for more details.
[Enable] [Disable]

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@alexfrancoeur
Copy link
Author

cc: @bmcconaghy

@pmuellr pmuellr self-assigned this Nov 12, 2019
@alexfrancoeur
Copy link
Author

Privacy statement link: https://www.elastic.co/legal/privacy-statement

@alexfrancoeur
Copy link
Author

@pmuellr I updated with the title and a quick tweak to the language. Should be good to go.

@pmuellr
Copy link
Member

pmuellr commented Nov 12, 2019

The banner's title "Help us improve the Elastic Stack!" had an exclamation point at the end, the new one suggested above does not. Just want to double-check that we DO NOT want the exclamation point in the title any more.

@pmuellr
Copy link
Member

pmuellr commented Nov 12, 2019

@alexfrancoeur notes that the exclamation point was deliberately removed

@pmuellr
Copy link
Member

pmuellr commented Nov 12, 2019

The original banner is a two-part thing, with a "Read more" link at the end that adds more text to the banner. Guessing that we no longer want that "Read more" link, so that all the text is in the banner when it appears.

Here's the banner as it appears today, before clicking the "Read more" link:

image

Here's the banner as it appears today, after clicking the "Read more" link:

image

@alexfrancoeur
Copy link
Author

@pmuellr yes, we can remove the "Read more" link. We have simplified the text and no longer require the additional information.

pmuellr added a commit to pmuellr/kibana that referenced this issue Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants