Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid specifying the same percentile multiple times #57444

Closed
timroes opened this issue Feb 12, 2020 · 1 comment · Fixed by #58299
Closed

Forbid specifying the same percentile multiple times #57444

timroes opened this issue Feb 12, 2020 · 1 comment · Fixed by #58299
Assignees
@ThomThomson
Labels
Feature:Vis Editor Visualization editor issues good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Feb 12, 2020

With elastic/elasticsearch#52257 Elasticsearch removes the ability to specify the same percentile value multiple times in a percentile aggregation. This will go into 8.0 since it's a breaking change. We should make sure we're also not allowing the user to specify two times the same percentile value in the visualize editor, since otherwise that request would start failing and the user doesn't have a clear error anymore what's happening. Instead the editor should show a clear error message on that, and make sure we can't save that state.
@timroes timroes added good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues labels Feb 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ThomThomson ThomThomson linked a pull request Feb 24, 2020 that will close this issue
Disallow duplicate percentiles (#57444) #58299
Merged
6 tasks
@ThomThomson ThomThomson mentioned this issue Feb 24, 2020
Merged
6 tasks
ThomThomson added a commit that referenced this issue Mar 2, 2020
@ThomThomson
Disallow duplicate percentiles (#57444) (#58299)
4696736 
Added an optional validation step to the number_list component to disallow duplicates, Reworked and consolidated number_list component validations into one method and enabled this option in the percentiles editor. Added unit / integration tests
gmmorris added a commit to gmmorris/kibana that referenced this issue Mar 3, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
5184196 
* master: (26 commits)
  [Endpoint] Alert Details Overview (elastic#58412)
  Service map language icons (elastic#58633)
  [SIEM] [Case] Comments to case view (elastic#58315)
  Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775)
  [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627)
  Dashboard a11y tests (elastic#58122)
  Downgrade "setting up plugin" log to debug (elastic#58776)
  [CI] Pipeline refactoring (elastic#56447)
  [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511)
  put params into short url instead of behind it (elastic#58846)
  show timepicker in timelion and tsvb (elastic#58857)
  improve graph missing workspace error message (elastic#58876)
  [Maps] direct Discover "visualize" to open Maps application (elastic#58549)
  Disallow duplicate percentiles (elastic#57444) (elastic#58299)
  removing references to visTypes uiExports (elastic#58337)
  [SIEM] Default the Timeline events filter to show All events (elastic#58953)
  [Remote clusters] Add indexManagement as required plugin (elastic#58915)
  [DOCS] Rework of main get started page (elastic#58260)
  [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348)
  [Endpoint] add resolver middleware (elastic#58288)
  ...
dgieselaar pushed a commit to dgieselaar/kibana that referenced this issue Mar 3, 2020
@ThomThomson @dgieselaar
Disallow duplicate percentiles (elastic#57444) (elastic#58299)
3acc2e8 
Added an optional validation step to the number_list component to disallow duplicates, Reworked and consolidated number_list component validations into one method and enabled this option in the percentiles editor. Added unit / integration tests
@ThomThomson ThomThomson mentioned this issue Mar 4, 2020
Merged
ThomThomson added a commit that referenced this issue Mar 5, 2020
@ThomThomson
Disallow duplicate percentiles (#57444) (#58299) (#59360)
0c12506 
Added an optional validation step to the number_list component to disallow duplicates, Reworked and consolidated number_list component validations into one method and enabled this option in the percentiles editor. Added unit / integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
Feature:Vis Editor Visualization editor issues good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow duplicate percentiles (#57444) ThomThomson/kibana
3 participants
@timroes @ThomThomson @elasticmachine