Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date-based filtering limits all histograms regardless of facet data #595

Closed
andrewmatthews opened this issue Oct 21, 2013 · 2 comments
Closed
Labels
notabug When the issue is closed this label Indicates that it wasn't a bug

Comments

@andrewmatthews
Copy link

When filtering on a date range (such as last 30 days), all histograms seem to only display data within that range, regardless of the facet data returned by ElasticSearch.

For our use case, we have an availability search engine, where a search has 2 dates: the date the search occurred, and the date being searched for. If we filter the dashboard to searches that occurred in the last 30 days, the search-for date histogram is also limited to the last 30 days, rather than dates in the future.

@rashidkpc
Copy link
Contributor

Filters are considered global in Kibana, adding this feature would require a significant refactor. Perhaps something we can look at down the road.

@andrewmatthews
Copy link
Author

The filter itself relates to a single date field, however all date fields have the filter applied. Why is this not a bug?

w33ble pushed a commit to w33ble/kibana that referenced this issue Sep 13, 2018
Closes elastic#595. 

### Summary

This moves the LESS layer of canvas to Sass. Moreso, the new sass now imports the EUI variable scope and functions so that we can consistently style Canvas going forward. I mostly switced out the old canvas vars for eui ones, but may have done a couple slight nudges if it was easy.

### How the sass layer works

Theres an index.scss file which now imports the core eui sass "invisibles". The file then loads the canvas main sass (and hackery). Past that, all individual component styles are now imported in this file. This makes it so that we can control the load order (and stop importing colors into each file). The only downside if you now need to add a line for every new sass file you create rather than have it automatically import into the component. This also makes Canvas load a single CSS file which has it's pros and cons, but isn't too big of a deal in the scheme of things.

### Testing

Pull down, check out the index file to grok how it works. Run the gulp command `npx gulp watch` and make some changes in a sass file.

Check for BREAKING visual regressions we aren't comfortable with. These will likely be around text and labels, because I removed some overly agressive naked selector defaults. I think they're necessary temporarily to avoid the nest trap. A later design PR will clean up the whole app, removing bootstrap and fix this stuff in more detail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notabug When the issue is closed this label Indicates that it wasn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants
@rashidkpc @andrewmatthews and others