Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade your license to access all connectors gets displayed when user is on gold license #64245

Closed
bhavyarm opened this issue Apr 22, 2020 · 3 comments · Fixed by #64865
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Feature:License Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Apr 22, 2020

Kibana version: 7.7.0 BC8

Elasticsearch version: 7.7.0 BC8

Server OS version: centos7_rpm

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Clicking on create connectors displays "Upgrade your license to access all connectors" message even when user is on gold license.

Screen Shot 2020-04-22 at 4 30 04 PM

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:License Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

I believe this is caused by ServiceNow which is platinum license and not available in the UI, should fix.

@mikecote mikecote added this to To-Do 7.8 (Ordered by priority) in Make it Action Apr 27, 2020
@pmuellr pmuellr self-assigned this Apr 29, 2020
@pmuellr pmuellr moved this from To-Do 7.8 (Ordered by priority) to In Progress in Make it Action Apr 29, 2020
@pmuellr
Copy link
Member

pmuellr commented Apr 29, 2020

It sort of feels like the simplest thing to do is to just never show the upgrade message if you're not at basic. For gold, do we really want to be be presenting the upgrade to platinum, regardless of whether actions are "visible" or not? I have a feeling this could get complex, and the easiest thing would just have a simple rule like "only show it when you have a basic license". Could be considered a "gold feature" - no upgrade messages!

pmuellr added a commit to pmuellr/kibana that referenced this issue Apr 30, 2020
resolves elastic#64245

Prior to this PR, the "Upgrade your license" banner in the connectors list
was displayed for gold licenses because the Service Now action requires
platinum, and the check only looked for any actions disabled by license.

Rather than display a different message for gold users, this PR changes the
banner display logic to check for any actions disabled by license that
also have a minimum required license of gold.  That means gold+ users
won't see the message, even for actions with a minimum required license of
platinum+.  Another perk of the gold license!

This will continue to display the banner for basic users, but will no longer
display it for gold users.  It also continues to not display it for trial,
platinum and enterprise users.
@pmuellr pmuellr moved this from In Progress to In Review in Make it Action Apr 30, 2020
pmuellr added a commit that referenced this issue May 4, 2020
…64865)

resolves #64245

Prior to this PR, the "Upgrade your license" banner in the connectors list
was displayed for gold licenses because the Service Now action requires
platinum, and the check only looked for any actions disabled by license.

Rather than display a different message for gold users, this PR changes the
banner display logic to check for any actions disabled by license that
also have a minimum required license of gold.  That means gold+ users
won't see the message, even for actions with a minimum required license of
platinum+.  Another perk of the gold license!

This will continue to display the banner for basic users, but will no longer
display it for gold users.  It also continues to not display it for trial,
platinum and enterprise users.
pmuellr added a commit to pmuellr/kibana that referenced this issue May 4, 2020
…lastic#64865)

resolves elastic#64245

Prior to this PR, the "Upgrade your license" banner in the connectors list
was displayed for gold licenses because the Service Now action requires
platinum, and the check only looked for any actions disabled by license.

Rather than display a different message for gold users, this PR changes the
banner display logic to check for any actions disabled by license that
also have a minimum required license of gold.  That means gold+ users
won't see the message, even for actions with a minimum required license of
platinum+.  Another perk of the gold license!

This will continue to display the banner for basic users, but will no longer
display it for gold users.  It also continues to not display it for trial,
platinum and enterprise users.
@pmuellr pmuellr moved this from In Review to Done (Ordered by most recent) in Make it Action May 4, 2020
pmuellr added a commit that referenced this issue May 4, 2020
…64865) (#65138)

resolves #64245

Prior to this PR, the "Upgrade your license" banner in the connectors list
was displayed for gold licenses because the Service Now action requires
platinum, and the check only looked for any actions disabled by license.

Rather than display a different message for gold users, this PR changes the
banner display logic to check for any actions disabled by license that
also have a minimum required license of gold.  That means gold+ users
won't see the message, even for actions with a minimum required license of
platinum+.  Another perk of the gold license!

This will continue to display the banner for basic users, but will no longer
display it for gold users.  It also continues to not display it for trial,
platinum and enterprise users.
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Feature:License Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Make it Action
  
Done (Ordered by most recent)
Development

Successfully merging a pull request may close this issue.

5 participants