[Alerting] only show trial upgrade when running with basic license #64865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves elastic#64245 Prior to this PR, the "Upgrade your license" banner in the connectors list was displayed for gold licenses because the Service Now action requires platinum, and the check only looked for any actions disabled by license. Rather than display a different message for gold users, this PR changes the banner display logic to check for any actions disabled by license that also have a minimum required license of gold. That means gold+ users won't see the message, even for actions with a minimum required license of platinum+. Another perk of the gold license! This will continue to display the banner for basic users, but will no longer display it for gold users. It also continues to not display it for trial, platinum and enterprise users.
pmuellr
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
LGTM 👍 I would confirm with @alexfrancoeur or @arisonl that the banner would only show for non-paying users (gold users won't see it anymore).
The "Get more actions" link still shows for gold users but I guess it's not aggressive enough to remove.
| const hasActionsDisabledByLicense = availableActionTypes.some( | ||
| action => !index[action.id].enabledInLicense | ||
| // determine if there are actions disabled by license that that | ||
| // would be enabled by upgrading to trial |
There was a problem hiding this comment.
nit: I would change the comment from trial to a gold license to be more clear on the logic below. Trial unlocks all license levels.
Suggested change
| // would be enabled by upgrading to trial | |
| // would be enabled by upgrading to a gold license |
| @@ -136,6 +136,100 @@ describe('connector_add_flyout', () => { | |||
| `"https://www.elastic.co/subscriptions"` | |||
| ); | |||
| }); | |||
|
|
|||
| it('does not render banner with subscription links when only platinum features are disabled due to licensing ', () => { | |||
|
@elasticmachine merge upstream |
|
from #64865 (review)
Confirmed. Noted that we may want to enhance this later to show a more "subtle" experience for gold+ users, in case there are actions that require an upgraded license given the current gold+ license, but for now, not showing it for gold+ is fine. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
May 4, 2020
…lastic#64865) resolves elastic#64245 Prior to this PR, the "Upgrade your license" banner in the connectors list was displayed for gold licenses because the Service Now action requires platinum, and the check only looked for any actions disabled by license. Rather than display a different message for gold users, this PR changes the banner display logic to check for any actions disabled by license that also have a minimum required license of gold. That means gold+ users won't see the message, even for actions with a minimum required license of platinum+. Another perk of the gold license! This will continue to display the banner for basic users, but will no longer display it for gold users. It also continues to not display it for trial, platinum and enterprise users.
pmuellr
added a commit
that referenced
this pull request
May 4, 2020
…64865) (#65138) resolves #64245 Prior to this PR, the "Upgrade your license" banner in the connectors list was displayed for gold licenses because the Service Now action requires platinum, and the check only looked for any actions disabled by license. Rather than display a different message for gold users, this PR changes the banner display logic to check for any actions disabled by license that also have a minimum required license of gold. That means gold+ users won't see the message, even for actions with a minimum required license of platinum+. Another perk of the gold license! This will continue to display the banner for basic users, but will no longer display it for gold users. It also continues to not display it for trial, platinum and enterprise users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #64245
Prior to this PR, the "Upgrade your license" banner in the connectors list
was displayed for gold licenses because the Service Now action requires
platinum, and the check only looked for any actions disabled by license.
Rather than display a different message for gold users, this PR changes the
banner display logic to check for any actions disabled by license that
also have a minimum required license of gold. That means gold+ users
won't see the message, even for actions with a minimum required license of
platinum+. Another perk of the gold license!
This will continue to display the banner for basic users, but will no longer
display it for gold users. It also continues to not display it for trial,
platinum and enterprise users.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist