Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] choropleth map with applyGlobalQuery set to false still creates filter for source. #64861

Closed
nreese opened this issue Apr 30, 2020 · 1 comment · Fixed by #108999
Closed

[Maps] choropleth map with applyGlobalQuery set to false still creates filter for source. #64861

nreese opened this issue Apr 30, 2020 · 1 comment · Fixed by #108999
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.16.0 v8.0.0
Projects
Maps

Comments

@nreese
Copy link
Contributor

nreese commented Apr 30, 2020 •
edited
Loading

Steps to view problem

  1. use geojson upload to ingest EMS world countries
  2. Install kibana web logs sample data set
  3. create a choropleth map with world countries as the vector source and web logs as the join.
  4. Add iso2 as tooltip field.
  5. Turn off Apply global filter to layer data under Filter header.
  6. Click a country to lock the tooltip in place
  7. Click plus icon next to iso2 field.
  8. notice how two filter pills get created. One for the layer source and one for the join source.

Expected behavior, when Apply global filter to layer data has been turned off, only a single filter pill gets created for the join source.

Screen Shot 2020-04-29 at 7 26 13 PM
@nreese nreese added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Apr 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@lizozom lizozom mentioned this issue May 21, 2020
Merged
7 tasks
lizozom pushed a commit to lizozom/kibana that referenced this issue May 27, 2020
Disable check in maps test until elastic#64861 is resolved
886477f
lizozom added a commit that referenced this issue Jun 3, 2020
@lizozom @cchaos @elasticmachine
Add error if filter index pattern is missing (#66979)
fbcb74c 
* add error if filter index pattern is gone

* docs change - why?

* Fix i18n

* Added a functional test for broken filters (field + index pattern)

* Clarify readme

* Moved readme

* New warning status

* Remove getAll

* git pull upstream master

* Fix translation files

* Fix merge

* added filterbar texts

* disabled correction

* Disable check in maps test until #64861 is resolved

* Fix tests, warning state is not disabled.

* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable

* Add an additional unrelaeted filter test

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Fixed test data

* Revert mapping

* Update data with missing test

* Update test to match data

* Code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom added a commit to lizozom/kibana that referenced this issue Jun 3, 2020
@lizozom @cchaos @elasticmachine
Add error if filter index pattern is missing (elastic#66979)
217a660 
* add error if filter index pattern is gone

* docs change - why?

* Fix i18n

* Added a functional test for broken filters (field + index pattern)

* Clarify readme

* Moved readme

* New warning status

* Remove getAll

* git pull upstream master

* Fix translation files

* Fix merge

* added filterbar texts

* disabled correction

* Disable check in maps test until elastic#64861 is resolved

* Fix tests, warning state is not disabled.

* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable

* Add an additional unrelaeted filter test

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Fixed test data

* Revert mapping

* Update data with missing test

* Update test to match data

* Code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom added a commit that referenced this issue Jun 3, 2020
@lizozom @cchaos @elasticmachine
Add error if filter index pattern is missing (#66979) (#68050)
8f1cdca 
* add error if filter index pattern is gone

* docs change - why?

* Fix i18n

* Added a functional test for broken filters (field + index pattern)

* Clarify readme

* Moved readme

* New warning status

* Remove getAll

* git pull upstream master

* Fix translation files

* Fix merge

* added filterbar texts

* disabled correction

* Disable check in maps test until #64861 is resolved

* Fix tests, warning state is not disabled.

* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable

* Add an additional unrelaeted filter test

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Fixed test data

* Revert mapping

* Update data with missing test

* Update test to match data

* Code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom added a commit to lizozom/kibana that referenced this issue Jun 5, 2020
@lizozom
Add error if filter index pattern is missing (elastic#66979)
7d5452d 
* add error if filter index pattern is gone

* docs change - why?

* Fix i18n

* Added a functional test for broken filters (field + index pattern)

* Clarify readme

* Moved readme

* New warning status

* Remove getAll

* git pull upstream master

* Fix translation files

* Fix merge

* added filterbar texts

* disabled correction

* Disable check in maps test until elastic#64861 is resolved

* Fix tests, warning state is not disabled.

* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable

* Add an additional unrelaeted filter test

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Fixed test data

* Revert mapping

* Update data with missing test

* Update test to match data

* Code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	test/functional/fixtures/es_archiver/dashboard/current/kibana/data.json.gz
majagrubic pushed a commit to majagrubic/kibana that referenced this issue Jun 5, 2020
@lizozom @cchaos @elasticmachine
Add error if filter index pattern is missing (elastic#66979)
ecdc2da 
* add error if filter index pattern is gone

* docs change - why?

* Fix i18n

* Added a functional test for broken filters (field + index pattern)

* Clarify readme

* Moved readme

* New warning status

* Remove getAll

* git pull upstream master

* Fix translation files

* Fix merge

* added filterbar texts

* disabled correction

* Disable check in maps test until elastic#64861 is resolved

* Fix tests, warning state is not disabled.

* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable

* Add an additional unrelaeted filter test

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Fixed test data

* Revert mapping

* Update data with missing test

* Update test to match data

* Code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@thomasneirynck thomasneirynck added this to To do in Maps Jun 18, 2020
@nreese nreese mentioned this issue Jun 23, 2020
Closed
@nreese nreese added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Aug 4, 2021
@nreese nreese self-assigned this Aug 17, 2021
@nreese nreese mentioned this issue Aug 17, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this issue Sep 22, 2021
@ThomThomson
Remove filters to avoid maps bug elastic#64861
968b203
ThomThomson added a commit to ThomThomson/kibana that referenced this issue Sep 27, 2021
@ThomThomson
clear filters to avoid maps but elastic#64861
9d64d6d
ThomThomson added a commit that referenced this issue Sep 27, 2021
@ThomThomson @kibanamachine
[7.15] [Dashboard] Retain Viewmode State in Session (#112302) (#112708)
3b9a381 
* [Dashboard] Retain Viewmode State in Session (#112302)

* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations

* clear filters to avoid maps but #64861

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.16.0 v8.0.0
Projects
No open projects
Maps
  
To do
Milestone
No milestone
3 participants
@nreese @thomasneirynck @elasticmachine