Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Jest Tests.x-pack/plugins/index_management/public/application/components/mappings_editor/__jest__/client_integration - Mappings editor: core tabs should keep the changes when switching tabs #66457

Closed
kibanamachine opened this issue May 13, 2020 · 5 comments · Fixed by #76672
Closed

Failing test: X-Pack Jest Tests.x-pack/plugins/index_management/public/application/components/mappings_editor/__jest__/client_integration - Mappings editor: core tabs should keep the changes when switching tabs #66457

kibanamachine opened this issue May 13, 2020 · 5 comments · Fixed by #76672
Assignees
@jloleysens
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.0

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

TypeError: state.templates.submitForm is not a function
    at changeTab (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx:99:71)
    at onClick (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx:131:38)
    at HTMLUnknownElement.callCallback (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at invokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
    at HTMLUnknownElementImpl._dispatch (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)
    at HTMLUnknownElement.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:143:21)
    at Object.invokeGuardedCallbackDev (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at invokeGuardedCallbackAndCatchFirstError (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:454:25)
    at executeDispatch (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:584:3)
    at executeDispatchesInOrder (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:609:5)
    at executeDispatchesAndRelease (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:713:5)
    at executeDispatchesAndReleaseTopLevel (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:722:10)
    at forEachAccumulated (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:694:8)
    at runEventsInBatch (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:739:3)
    at /var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1560:7
    at Object.batchedUpdates$1 [as unstable_batchedUpdates] (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:24386:12)
    at eventFn (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1556:14)
    at fn (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:490:11)
    at /var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:354:37
    at batchedUpdates$1 (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:24386:12)
    at Object.act (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1092:14)
    at wrapAct (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:354:13)
    at Object.simulateEvent (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:489:9)
    at ReactWrapper.call (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/enzyme/src/ReactWrapper.js:666:22)
    at ReactWrapper.single (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/enzyme/src/ReactWrapper.js:1170:21)
    at ReactWrapper.simulate (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/enzyme/src/ReactWrapper.js:665:17)
    at selectTab (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/__jest__/client_integration/helpers/mappings_editor.helpers.tsx:211:16)
    at /var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/__jest__/client_integration/mappings_editor.test.tsx:198:15
    at batchedUpdates$1 (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom.development.js:24386:12)
    at act (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1092:14)
    at Object.test (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/__jest__/client_integration/mappings_editor.test.tsx:197:13)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@spalger spalger added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

spalger added a commit that referenced this issue May 13, 2020
@spalger
skip flaky suite (#66457)
512ab5b
spalger added a commit that referenced this issue May 13, 2020
@spalger
skip flaky suite (#66457)
66e9b93 
(cherry picked from commit 512ab5b)
@spalger
Copy link
Contributor

spalger commented May 13, 2020

Looks like this is a renamed version of #65006

Between those two tests we've seen 8 failures going back to 7.8 (which doesn't include the rename from https://github.com/elastic/kibana/pull/63853/files#diff-da306a9b31f17ed01ce36fb262d3a713). Because the tests no longer match between 7.8 and 7.9 I'm not going to skip in 7.8 but I recommend backporting the test changes in #63853 if possible.

image

Skipped

master: 512ab5b
7.x/7.9: 66e9b93

@spalger spalger mentioned this issue May 13, 2020
Closed
@cjcenizal
Copy link
Contributor

@sebelga Can you confirm that this is one of the tests you're going to address during the 7.10 dev cycle?

@sebelga
Copy link
Contributor

sebelga commented Aug 3, 2020

@cjcenizal yes this should be addressed when unskipping the index management tests.

@sebelga sebelga mentioned this issue Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jloleysens jloleysens

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Index management] Unskip jest tests sebelga/kibana
6 participants
@cjcenizal @spalger @sebelga @jloleysens @elasticmachine @kibanamachine