[Index management] Unskip jest tests

[sebelga]

PR to unskip our tests in the Index management app.

I fixed a small regression where the index settings were not read by the mappings editor and thus the analyzer "custom" select was not displayed to chose a possible custom analyzer defined in the index settings.

Index management

Fixes #59849
Fixes #67833
Fixes #65567
Fixes #66669
Fixes #66457

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[sebelga]

@elasticmachine merge upstream

[sebelga]

@elasticmachine merge upstream

[cjcenizal]

@elasticmachine merge upstream

[cjcenizal]

@elasticmachine merge upstream

[cjcenizal]

@elasticmachine merge upstream

[cjcenizal]

@elasticmachine merge upstream

[sebelga]

@elasticmachine merge upstream

[sebelga]

@elasticmachine merge upstream

[yuliacech]

Hi @sebelga ,
great job on fixing these flaky test! Changes look good to me, I just have a couple questions to better understand the flakiness of the tests.

• I noticed you deleted nextTick in test files in __jest__/client_integration/index_template_wizard/, which I think was the main reason for flakiness, right? So do jest.useFakeTimers() and jest.useRealTimers() change anything further in these tests? I was not able to see any flakiness locally with jest timers removed.
• Similar question is for tests in /public/application/components/: Following your changes, I believe you fixed flaky tests by placing async UI actions outside of act and await them. Do you still need jest timers here?

[sebelga]

So the jest.useFakeTimers() gives us the guarantee to not use real timers. Not only in our test but in the code under test. So I do like to have it defined on top of my test to make sure that anything should work without a timer. If the test does not pass, it probably means that the consumer require some time to pass, and in that case we would manually add that time in the test.

I was not able to see any flakiness locally with jest timers removed.

The flakiness that we got on our tests only showed up in CI as all the tests are run in parallel and stress the machine. Locally we only run a tiny portion of them and the flakiness is very hard to detect.

[yuliacech]

I see, @sebelga , thanks a lot for your explanation! I'm good with merging and looking forward to learning more about tests from you :)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 16db7d2

Build metrics

async chunks size

id	value	diff	baseline
indexManagement	1.5MB	+2.4KB	1.5MB

History

• 💚 Build #73962 succeeded a14f472
• 💚 Build #73960 succeeded d5c3d41
• 💚 Build #73955 succeeded 495e06a
• 💚 Build #73952 succeeded 164a49c
• 💚 Build #73929 succeeded d260388

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[sebelga]

Thanks for the review @yuliacech ! Giving it another 20 passes and then merging 😊 https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/831/