Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expressions] var_set should be allowed to set multiple variables in parallel #69316

Closed
wylieconlon opened this issue Jun 16, 2020 · 5 comments · Fixed by #100458
Closed

[Expressions] var_set should be allowed to set multiple variables in parallel #69316

wylieconlon opened this issue Jun 16, 2020 · 5 comments · Fixed by #100458
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort review

Comments

@wylieconlon
Copy link
Contributor

Based on the approach described in #68457 where we want to set variables to contain the results of esaggs, it is important to run the data fetching in parallel. Therefore we need to be able to set multiple variables, for example:

var_set name="table1" value={esaggs ...} name="table2" value={esaggs ...}

I think this is a small change to the var_set code, by changing both name and value to be multi-value instead of single-value.

@ppisljar @streamich @flash1293

@wylieconlon wylieconlon added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Jun 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine kibanamachine added this to To triage in kibana-app-arch Jun 16, 2020
@ppisljar
Copy link
Member

as var_set just passes the context thru i don't think thats a requirement, you can do:

var_set name="table1" value={esaggs...} | var_set name="table2" value={esaggs...}

but i agree that this should not be hard to add

@ppisljar ppisljar added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort triaged labels Jun 17, 2020
@flash1293
Copy link
Contributor

@ppisljar But wouldn't the first var_set wait till the value sub-expression has completed? In this case that would mean that the second esaggs call would wait for the first esaggs call - with a multi set both can run in parallel.

@ppisljar
Copy link
Member

even with multiset i am not sure they would run in parallel, as the function (var_set in this case) does not get expression strings passed in but those expressions already evaluated. It depends how exactly interpreter does that argument resolution, but you are right it should at least be possible to make it work in parallel.

@ppisljar ppisljar added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 18, 2020
@flash1293
Copy link
Contributor

It might be possible to not evaluate the value sub expressions automatically by the interpreter, so the implementation of var_set can kick them off in parallel.

@streamich streamich mentioned this issue Jul 13, 2020
20 tasks
@lukeelmers lukeelmers moved this from To triage to 7.11 - Tentative in kibana-app-arch Jul 22, 2020
@exalate-issue-sync exalate-issue-sync bot added loe:large Large Level of Effort and removed loe:medium Medium Level of Effort labels Apr 20, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:large Large Level of Effort labels Apr 28, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
kibana-app-arch automation moved this from 7.11 to Done in current release Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort review
Projects
kibana-app-arch
  
Done in current release
Development

Successfully merging a pull request may close this issue.

5 participants