Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for setting multiple variables to varSet #100458

Merged
merged 6 commits into from Jun 14, 2021

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented May 24, 2021

Summary

var_set expression function now supports setting multiple variables at once.

resolves #69316

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ppisljar ppisljar added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels May 24, 2021
@ppisljar ppisljar requested a review from a team as a code owner May 24, 2021 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@ppisljar
Copy link
Member Author

ppisljar commented Jun 7, 2021

@elasticmachine merge upstream

@ppisljar
Copy link
Member Author

ppisljar commented Jun 8, 2021

@elasticmachine merge upstream

Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM.

@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

@ppisljar ppisljar merged commit 2dbf680 into elastic:master Jun 14, 2021
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jun 14, 2021
@ppisljar ppisljar added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Jun 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressions 1467 1469 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 202.7KB 202.8KB +80.0B
Unknown metric groups

API count

id before after diff
expressions 1894 1896 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon added release_note:enhancement and removed release_note:feature Makes this part of the condensed release notes labels Jun 15, 2021
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:enhancement v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Expressions] var_set should be allowed to set multiple variables in parallel
5 participants