[4.x] Bump elasticsearch-js version to the latest stable

[andrewjkenney]

Edit by @epixa

We should bump the elasticsearch-js version in 4.x to the latest stable version possible.

---

Original title: npm install fails due to node_module version incompatibility with 4.4.4

When following the contributing.md instructions to do a fresh install I get an incompatibility for elasticsearch and also karma. This happened for me on branch 4.5, I have observed similar on 4.5.1 and 4.1

on 4.5 branch, If I bump

• elasticsearch to 9.0.2
• karma to 0.13.22

npm install works

npm ERR! node v4.4.4
npm ERR! npm  v2.15.1
npm ERR! code ENOTSUP

npm ERR! notsup Unsupported
npm ERR! notsup Not compatible with your version of node/npm: elasticsearch@8.0.1
npm ERR! notsup Required: {"node":">=0.8 <3.0","iojs":">=1.5"}
npm ERR! notsup Actual:   {"npm":"2.15.1","node":"4.4.4"}

npm ERR! notsup Unsupported
npm ERR! notsup Not compatible with your version of node/npm: karma@0.13.9
npm ERR! notsup Required: {"node":">=0.10 <=0.12 || >=1 <=3"}
npm ERR! notsup Actual:   {"npm":"2.15.1","node":"4.4.4"}

[epixa]

I just did a test of a fresh clone of 4.5, and I'm not seeing this. Is this still an issue? Do you have any other details?

[andrewjkenney]

I had to update the package.json to newer versions. In the end I chose elasticsearch 8.1. This was the earliest version of that module that supported node v4.4.4
deps:
"elasticsearch": "8.1.0",
"elasticsearch-browser": "8.1.0",
dev deps:
"karma": "0.13.22",

I'm not sure why you can't reproduce. npm only does these version checks at install time. If you used a version of node in the acceptable range to run install it may have downloaded.

On another project, we ran into version issues with fresh installs due to 3rd party dependencies and their dependencies... so we started maintaining a shrinkwrap file.

I'll try a fresh clone over the weekend and see if it's still a problem for me.

[andrewjkenney]

I setup a simple test confirming that npm won't download elasticsearch 8.0.1 with node v4.4.4:

mac~$ cat package.json 
{
  "name": "test",
  "version": "1.0.0",
  "description": "a random test",
  "main": "index.js",
  "scripts": {
    "test": "ls"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "elasticsearch": "8.0.1"
  }
}
mac~$ npm install
npm WARN package.json test@1.0.0 No repository field.
npm WARN package.json test@1.0.0 No README data
npm ERR! Darwin 15.4.0
npm ERR! argv "/Users/me/.nvm/versions/node/v4.4.4/bin/node" "/Users/akenney/.nvm/versions/node/v4.4.4/bin/npm" "install"
npm ERR! node v4.4.4
npm ERR! npm  v2.15.1
npm ERR! code ENOTSUP

npm ERR! notsup Unsupported
npm ERR! notsup Not compatible with your version of node/npm: elasticsearch@8.0.1
npm ERR! notsup Required: {"node":">=0.8 <3.0","iojs":">=1.5"}
npm ERR! notsup Actual:   {"npm":"2.15.1","node":"4.4.4"}

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/me/dev/gitrepo/sandbox/test/npm-debug.log
mac~$ nvm list
       v0.10.45
         v4.3.2
->       v4.4.4
         v5.7.0
         v5.7.1
         system
default -> stable (-> v5.7.1)
node -> stable (-> v5.7.1) (default)
stable -> 5.7 (-> v5.7.1) (default)
iojs -> N/A (default)

[Bargs]

I get a warning, but not a failure (with node 4.4.7 and npm 2.15.8):

npm WARN engine elasticsearch@8.0.1: wanted: {"node":">=0.8 <3.0","iojs":">=1.5"} (current: {"node":"4.4.7","npm":"2.15.8"})

As I understand, the install should only fail if the dependency lists engineStrict: true in its package.json, which elasticsearch.js does not. Do you have something configured in your local npm that makes all engine checks strict, perhaps?

[epixa]

While I don't see us bumping this for 4.5, we probably should update it in 4.x so that we don't run into problems in the future while maintaining 4.6. @spalger What do you think? Is there an obvious version of the es-js client that we should use against ES 2.4?

[spalger]

Every version of the elasticsearch-js client works against every version of elasticsearch released since 0.90. Just supply the apiVersion: '2.4' configuration parameter.

[epixa]

That's convenient.

[Bargs]

Every version of the elasticsearch-js client works against every version of elasticsearch released since 0.90.

@spalger

[epixa]

@andrewjkenney I hope you don't mind that I commandeered this ticket for the dependency bump. It seemed appropriate since this ticket provides all of the context.

[andrewjkenney]

Sure no problem.

@Bargs is right, under normal config you would only receive a warning. But, I have engine-strict=true in my local config. and forgot it was set.

I think I turned it on before we started shrinkwrapping...

[epixa]

@spalger I think there was a backwards compatibility break in the elasticsearch-js plugin at some point between 8.x and 12.x. If I bump the elasticsearch and elasticsearch-browser dependencies to 12.1.2 in the 4.6 branch, I consistently get the following error during optimize:

/p/kibana-4.6/src/plugins/elasticsearch/lib/health_check.js:96
      check()['finally'](function () {
                        ^

TypeError: check(...).finally is not a function
    at Timeout._onTimeout (/p/kibana-4.6/src/plugins/elasticsearch/lib/health_check.js:99:22)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)
 server crashed  with status code 1

That's with a completely fresh node_modules.

[spalger]

@epixa yeah, we'll need to backport #5656 1e507a9

[spalger]

esjs used to ship with bluebird, but that was removed in support of native JS promises. We configure the library to use bluebird though

[epixa]

Awesome, I'll sort that out.

[epixa]

It looks like the latest version of elasticsearch-js (12.1) does not support the ES 2.0 api, which is a requirement for 4.x. Since the default npm settings work for the current version, I'm going to close this out.