Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Visualization Y-Axis aggregation not reflected in data table #7211

Closed
LeeDr opened this issue May 16, 2016 · 5 comments · Fixed by #13130
Closed

Change to Visualization Y-Axis aggregation not reflected in data table #7211

LeeDr opened this issue May 16, 2016 · 5 comments · Fixed by #13130
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@LeeDr
Copy link
Contributor

LeeDr commented May 16, 2016

I see this on 4.5.1-rc1 (although I doubt is has anything to do with the node version bump in this rc.

I'm using Chrome browser. Same problem on Firefox.

Notice that the data table second column is "Sum of phpmemory" but I had previously changed the Y-Axis aggregation from phpmemory to bytes and applied that change. The green Go arrow is currently disabled so it's not a change that hasn't been applied.

2016-05-16 11_05_01-visualize - kibana

If I collapse the data table (expand the chart) and then show the data table again it is properly updated to the new Y-Axis agg (and notice that the numbers didn't change, so I think it was showing correct numbers with a stale heading);

2016-05-16 11_08_54-visualize - kibana

In this gif I change from phpmemory to bytes, and you see that the data table still shows phpmemory until I collapse and expand it;

filter

@LeeDr LeeDr added bug Fixes for quality problems that affect the customer experience Feature:Add Data Add Data and sample data feature on Home P2 and removed Feature:Add Data Add Data and sample data feature on Home labels May 16, 2016
@LeeDr
Copy link
Contributor Author

LeeDr commented May 16, 2016

I verified that the same problem exists in Kibana 4.4.2.

@tbragin tbragin added Feature:Data Table Data table visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Nov 1, 2016
@ppisljar ppisljar added P3 and removed P2 labels Feb 7, 2017
@ppisljar
Copy link
Member

ppisljar commented Feb 7, 2017

this is present on master as well and it doesnt just affect data table. whole spy panel doesn't refresh until you collapse/expand it again.

@nreese
Copy link
Contributor

nreese commented Jul 24, 2017

@thomasneirynck @ppisljar
The spy table headers do not update because the paginated-table directive uses a one-way data binding ::columns. Is there a reason why the table headers are rendered with a one-way data binding?

@ppisljar
Copy link
Member

@nreese no idea, maybe @spalger knows ?

@spalger
Copy link
Contributor

spalger commented Jul 25, 2017

@nreese @ppisljar there was a minor obsession with bind-once behavior a while back, but the only reason it's useful is performance (It's not actually one-way data binding) it can be safely removed since it's not actually benefitting us here

jbudz pushed a commit that referenced this issue Sep 27, 2023
`v88.3.0`⏩`v88.5.0`

closes #151514

---

## [`88.5.0`](https://github.com/elastic/eui/tree/v88.5.0)

- Updated `EuiCallOut` with a new `onDismiss` prop
([#7156](elastic/eui#7156))
- Added a new `renderCustomToolbar` prop to `EuiDataGrid`, which allows
custom rendering of the toolbar.
([#7190](elastic/eui#7190))
- Added a new `allowResetButton` prop to
`toolbarVisibility.showDisplaySelector` of `EuiDataGrid`, which allows
hiding the "Reset to default" button from the display settings popover.
([#7190](elastic/eui#7190))
- Added a new `additionalDisplaySettings` prop to
`toolbarVisibility.showDisplaySelector` of `EuiDataGrid`, which allows
rendering extra settings inside the display settings popover.
([#7190](elastic/eui#7190))
- Updated `EuiDataGrid`'s toolbar display settings button icon
([#7190](elastic/eui#7190))
- Updated `EuiTextTruncate` with significantly improved iteration
performance. Removed `measurementRenderAPI` prop, as `EuiTextTruncation`
now only uses more performant canvas render API
([#7210](elastic/eui#7210))
- Updated `EuiPopover` with a new configurable `repositionToCrossAxis`
prop ([#7211](elastic/eui#7211))
- Updated `EuiDatePicker` to support `compressed` input styling
([#7218](elastic/eui#7218))
- Added `gradient` and `palette` icon glyphs.
([#7220](elastic/eui#7220))

**Bug fixes**

- Fixed `EuiPopover`'s missing animations on popover close
([#7211](elastic/eui#7211))
- Fixed `EuiInputPopover` anchoring to the wrong side and missing
shadows on smaller screens
([#7211](elastic/eui#7211))
- Fixed `EuiSuperDatePicker` icon spacing on the quick select button
([#7217](elastic/eui#7217))
- Fixed a missing type in `EuiMarkdownEditor`'s default processing
plugins ([#7221](elastic/eui#7221))


## [`88.4.1`](https://github.com/elastic/eui/tree/v88.4.1)

**Bug fixes**

- Fixed missing `className`s on `EuiTextTruncate`
([#7212](elastic/eui#7212))
- Fixed `title`s on `EuiComboBox` dropdown options to always be present
([#7212](elastic/eui#7212))
- Fixed `EuiComboBox` truncation issues when search is an empty space
([#7212](elastic/eui#7212))

## [`88.4.0`](https://github.com/elastic/eui/tree/v88.4.0)

- Updated `EuiComboBox` to allow configuring text truncation behavior
via `truncationProps`. These props can be set on the entire combobox as
well as on on individual dropdown options.
([#7028](elastic/eui#7028))
- Updated `EuiInMemoryTable` with a new `searchFormat` prop (defaults to
`eql`). When setting this prop to `text`, the built-in search bar will
ignore EQL syntax and allow searching for plain strings with special
characters and symbols.
([#7175](elastic/eui#7175))

**Bug fixes**

- `EuiComboBox` now always shows the highlighted search text, even on
truncated text ([#7028](elastic/eui#7028))
- Fixed missing i18n in `EuiSearchBar`'s default placeholder and
aria-label text ([#7175](elastic/eui#7175))
- Fixed the inline compressed styles of `EuiDescriptionListTitle` to use
a taller line-height for readability
([#7185](elastic/eui#7185))
- Fixed `EuiComboBox` to correctly truncate selected items when
displayed as pills and plain text
([#7193](elastic/eui#7193))

**Accessibility**

- Added `aria-current` attribute to `EuiTablePagination`
([#7186](elastic/eui#7186))

**CSS-in-JS conversions**

- Converted `EuiDroppable` and `EuiDraggable` to Emotion; Removed
`$euiDragAndDropSpacing` Sass variables
([#7187](elastic/eui#7187))

---------

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
Co-authored-by: Thomas Watson <watson@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants