Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization IPv4 Range Aggregation #8736

Closed
kobelb opened this issue Oct 18, 2016 · 0 comments · Fixed by #8740
Closed

Visualization IPv4 Range Aggregation #8736

kobelb opened this issue Oct 18, 2016 · 0 comments · Fixed by #8740
Assignees
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@kobelb
Copy link
Contributor

kobelb commented Oct 18, 2016

When creating a visualization and selecting the IPv4 Range aggregation, the data is not being displayed properly.

For example, when creating a "Vertical Bar Graph" with 3 ranges, we'll get a single bar labeled "-":

screen shot 2016-10-18 at 4 57 49 pm

The Data Table visualization displays each individual range, but the labels are all '-':

screen shot 2016-10-18 at 4 59 42 pm

@kobelb kobelb added the bug Fixes for quality problems that affect the customer experience label Oct 18, 2016
@Bargs Bargs self-assigned this Oct 18, 2016
Bargs added a commit to Bargs/kibana that referenced this issue Oct 18, 2016
Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets
when from/to is used in the request. Looking at the [2.x docs][1] it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.

[1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html

Fixes: elastic#8736
elastic-jasper added a commit that referenced this issue Oct 19, 2016
---------

**Commit 1:**
Generate key for ip range from/to agg

Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets
when from/to is used in the request. Looking at the [2.x docs][1] it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.

[1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html

Fixes: #8736

* Original sha: f344a4b
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T22:51:56Z

**Commit 2:**
Stop sending null in ip range from/to props

The IP range agg supports open ended ranges. Elasticsearch 2.x was
lenient and accepted null as a value for the from/to props, but the
correct way to do an open ended range was always to omit the from/to
key entirely. ES 5.0 appears to be more strict and barfs when null is
passed. This commit removes the null values.

Fixes #8741

* Original sha: 3ca45ba
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T23:18:14Z

**Commit 3:**
ip range label and filter improvements

* updated the filter labels to match the range labels
* fixed the filter creation to work for unbound ranges

* Original sha: b153ea0
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T17:57:58Z
* Committed by Matthew Bargar <mbargar@gmail.com> on 2016-10-19T18:36:22Z
elastic-jasper added a commit that referenced this issue Oct 19, 2016
---------

**Commit 1:**
Generate key for ip range from/to agg

Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets
when from/to is used in the request. Looking at the [2.x docs][1] it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.

[1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html

Fixes: #8736

* Original sha: f344a4b
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T22:51:56Z

**Commit 2:**
Stop sending null in ip range from/to props

The IP range agg supports open ended ranges. Elasticsearch 2.x was
lenient and accepted null as a value for the from/to props, but the
correct way to do an open ended range was always to omit the from/to
key entirely. ES 5.0 appears to be more strict and barfs when null is
passed. This commit removes the null values.

Fixes #8741

* Original sha: 3ca45ba
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T23:18:14Z

**Commit 3:**
ip range label and filter improvements

* updated the filter labels to match the range labels
* fixed the filter creation to work for unbound ranges

* Original sha: b153ea0
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T17:57:58Z
* Committed by Matthew Bargar <mbargar@gmail.com> on 2016-10-19T18:36:22Z
spalger pushed a commit that referenced this issue Oct 19, 2016
---------

**Commit 1:**
Generate key for ip range from/to agg

Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets
when from/to is used in the request. Looking at the [2.x docs][1] it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.

[1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html

Fixes: #8736

* Original sha: f344a4b
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T22:51:56Z

**Commit 2:**
Stop sending null in ip range from/to props

The IP range agg supports open ended ranges. Elasticsearch 2.x was
lenient and accepted null as a value for the from/to props, but the
correct way to do an open ended range was always to omit the from/to
key entirely. ES 5.0 appears to be more strict and barfs when null is
passed. This commit removes the null values.

Fixes #8741

* Original sha: 3ca45ba
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T23:18:14Z

**Commit 3:**
ip range label and filter improvements

* updated the filter labels to match the range labels
* fixed the filter creation to work for unbound ranges

* Original sha: b153ea0
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T17:57:58Z
* Committed by Matthew Bargar <mbargar@gmail.com> on 2016-10-19T18:36:22Z
nreese pushed a commit to nreese/kibana that referenced this issue Nov 10, 2016
Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets
when from/to is used in the request. Looking at the [2.x docs][1] it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.

[1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html

Fixes: elastic#8736
airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
---------

**Commit 1:**
Generate key for ip range from/to agg

Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets
when from/to is used in the request. Looking at the [2.x docs][1] it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.

[1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html

Fixes: elastic#8736

* Original sha: 4ce57ac7ddde0c889741d26dbbfe30440a0fc5fb [formerly f344a4b]
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T22:51:56Z

**Commit 2:**
Stop sending null in ip range from/to props

The IP range agg supports open ended ranges. Elasticsearch 2.x was
lenient and accepted null as a value for the from/to props, but the
correct way to do an open ended range was always to omit the from/to
key entirely. ES 5.0 appears to be more strict and barfs when null is
passed. This commit removes the null values.

Fixes elastic#8741

* Original sha: 70426f51c074459821730a8afcd0771f97eb9752 [formerly 3ca45ba]
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T23:18:14Z

**Commit 3:**
ip range label and filter improvements

* updated the filter labels to match the range labels
* fixed the filter creation to work for unbound ranges

* Original sha: f3f4fea563b229a9e655b0aa1a9803f3ee7b3091 [formerly b153ea0]
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T17:57:58Z
* Committed by Matthew Bargar <mbargar@gmail.com> on 2016-10-19T18:36:22Z


Former-commit-id: c248419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants