Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Vector tile layer with only line features shows Polygon styling in Layer Style UI #92672

Closed
kindsun opened this issue Feb 24, 2021 · 8 comments
Labels
blocked bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.

Comments

@kindsun
Copy link
Contributor

kindsun commented Feb 24, 2021

Currently tracks layers default to polygon styling which is confusing for the user since "fill color" won't really apply, but it's the first option listed when you go to style the tracks layer

2021-02-24_10-42

@kindsun kindsun added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.12.0 labels Feb 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun
Copy link
Contributor Author

kindsun commented Feb 24, 2021

Actually this is a user error. Closing!

@kindsun kindsun closed this as completed Feb 24, 2021
@kindsun kindsun changed the title [Maps] Geo lines/tracks default to polygon styling [Maps] Geo lines default to polygon styling Feb 24, 2021
@kindsun
Copy link
Contributor Author

kindsun commented Feb 24, 2021

Reopening, this is valid for Geo lines using the following instructions:

  1. Use GeoJSON uploader to upload this file
  2. Follow through the normal layer adding process

@kindsun kindsun reopened this Feb 24, 2021
@nreese
Copy link
Contributor

nreese commented Feb 25, 2021

Closing.

In the description screen shot, the icon is a vector tile layer icon meaning the Documents layer has scaling set to "Use vector tiles". There is no feature meta data available for vector tile layers so the styling UI does not know that the source is only lines.

If you set scaling to "Limit" then the form correctly selects lines displaying the styling UI. The only caveat to this is if the layer panel is opened before the layer has finished syncing data. Then the UI defaults to showing polygon styling because feature meta data not yet available.

@nreese nreese closed this as completed Feb 25, 2021
@nreese nreese changed the title [Maps] Geo lines default to polygon styling [Maps] Layer with only lines sometimes shows Polygon styling in Layer Style UI Feb 25, 2021
@nreese nreese changed the title [Maps] Layer with only lines sometimes shows Polygon styling in Layer Style UI [Maps] Layer with only line features sometimes shows Polygon styling in Layer Style UI Feb 25, 2021
@kindsun kindsun changed the title [Maps] Layer with only line features sometimes shows Polygon styling in Layer Style UI [Maps] Vector tile layer with only line features shows Polygon styling in Layer Style UI Feb 25, 2021
@kindsun
Copy link
Contributor Author

kindsun commented Feb 25, 2021

There is no feature meta data available for vector tile layers so the styling UI does not know that the source is only lines.

Point well taken, and I understand the solution isn't so straightforward with vector tiles, but I believe this should be captured as a UX issue. The solution might be as simple as swapping the locations of the Fill color and Border color adjustments and possibly renaming Border color. As it stands right now, when you have a vector tile line layer and go to adjust what appears to be the first valid adjustment, nothing happens and it's confusing.

We might also consider disabling Lines and Points and just having one well thought out style menu that has a logical flow for covering data we don't entirely know the shape of.

@kindsun kindsun reopened this Feb 25, 2021
@nreese
Copy link
Contributor

nreese commented Feb 25, 2021

We might also consider disabling Lines and Points and just having one well thought out style menu that has a logical flow for covering data we don't entirely know the shape of.

I still recommend closing this issue. This is not something I see us addressing in the next 6 months and is a minor UX issue. I think it would be best to close this issue to try and keep our issue list only containing issue that will likely get addressed.

@thomasneirynck
Copy link
Contributor

It's ok to keep this open I think. There's a backend issue on the ES-side that is blocking this. elastic/elasticsearch#49569

Given that all .mvt work is in flux right now (potentially having mvt generation pushed down into the ES-layer - elastic/elasticsearch#58696), I agree that this is a hard one to prioritize.

@thomasneirynck
Copy link
Contributor

#92672 closes this for ES-data. The effort to solve this for 3rd party services, which do not provide any metadata about the geometries in the tile is likely not worth the benefit.

i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.
Projects
None yet
Development

No branches or pull requests

4 participants