Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Fit to data doesn't work in TMS #92741

Closed
kindsun opened this issue Feb 25, 2021 · 6 comments · Fixed by #95980
Closed

[Maps] Fit to data doesn't work in TMS #92741

kindsun opened this issue Feb 25, 2021 · 6 comments · Fixed by #95980
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects

Comments

@kindsun
Copy link
Contributor

kindsun commented Feb 25, 2021

Fit to data doesn't currently do anything in TMS. It's not entirely clear if this should be an option for this layer type. We should consider graying it out, removing it, or if it is supposed to do something, connecting that logic.

image

To reproduce:

  1. Go to Add layer > Tile map service
  2. Add the following URL: http://c.tile.stamen.com/watercolor/{z}/{x}/{y}.jpg
  3. Skip atrribution and Add layer
  4. Click on the new layer in the TOC and attempt to Fit to data
@kindsun kindsun added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun
Copy link
Contributor Author

kindsun commented Feb 25, 2021

Related to #70146

@thomasneirynck
Copy link
Contributor

Agreed that UX is wonky here. Graying out when a layer-type does not support fit2 layer (e.g. in the case of a raster layer) makes sense to me.

@thomasneirynck thomasneirynck added this to Backlog in Maps Feb 25, 2021
@kmartastic
Copy link
Contributor

kmartastic commented Feb 25, 2021

@aaronjcaldwell @thomasneirynck I actually like removing it, because it will never be enabled on this menu (for this layer type)... or would it be if the tile layer had a small extent?

Arguing against myself -- it is such a commonly used menu; that muscle memory and consistency of position might be more important.

@kindsun
Copy link
Contributor Author

kindsun commented Feb 25, 2021

Arguing against myself -- it is such a commonly used menu; that muscle memory and consistency of position might be more important.

@kmartastic I guess I'm more in this camp. All of the options except this one are consistent and applicable to all other layer types so seems easiest just to keep the same options but grey this one out here. That said, I'm not passionate about it so happy to jump on the removal bandwagon if anyone feels strongly.

@kmartastic
Copy link
Contributor

@miukimiu What do you think?

Consistent position on layer menu, but disabled.
vs
A disabled menu option that can never be enabled given it's context (layer type doesn't support option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects
No open projects
Maps
  
Backlog
Development

Successfully merging a pull request may close this issue.

5 participants