[Maps] fix fit to data doesn't work in TMS #95980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
approved these changes
Apr 1, 2021
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Apr 1, 2021
nreese
added a commit
that referenced
this pull request
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92741
TOCEntryActionsPopover uses layer.supportsFitToBounds is used to determine if "Fit to data" should be enabled or disabled. layer.supportsFitToBounds just calls source.supportsFitToBounds. The problem is that source.supportsFitToBounds defaulted to true so that pretty much all sources said they supported fitting to data. This PR fixes the problem by defaulting supportsFitToBounds to false and then only turning on supportsFitToBounds by default for vector sources.