Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Customize event rendering under timeline area was disabled on all browser #92798

Closed
ghost opened this issue Feb 25, 2021 · 11 comments · Fixed by #93150
Closed

[Security Solution]Customize event rendering under timeline area was disabled on all browser #92798

ghost opened this issue Feb 25, 2021 · 11 comments · Fixed by #93150
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0

Comments

@ghost
Copy link

ghost commented Feb 25, 2021

Describe the bug
customize event rendering under timeline area was disabled on all browser

Build Details:

Platform: Production
Version: 7.12.0 BC2
Commit: 4f65a5a1268fa78f1af9117d12312e1cee433376
Build:39000

Browser Details

Edge : 88.0.705.74 
Safari: 13.1.2 [13609.3.5.1.5]
Firefox: 86.0 
Chrome: 88.0.4324.190

Preconditions
1.Elastic Cloud environment having version 7.12.0 should be available.
2.Audit beat should be installed on above environment.

Steps to Reproduce

  1. Navigate to Kibana and Select Security Solution App from the left navigation panel.
  2. Go to Timeline Tab.
  3. Enter any filter Query "host.name: "*" " in the timeline search bar.
  4. Click on customize event rendering button.
  5. Observed the Customize event rendering page was disabled for user to perform any action.

Actual Result
Customize event rendering under timeline area was disabled on all browser

Expected Result
Customize event rendering under timeline area should open correctly and accessible to user.

Whats Working

  • N/A

Whats Not Working

  • N/A

Screenshots

image
image

logs
N/A
@ghost ghost added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 25, 2021
@ghost
Copy link
Author

ghost commented Feb 25, 2021

Assigned to @MadameSheema

@ghost ghost assigned MadameSheema Feb 25, 2021
@MadameSheema MadameSheema added the Team:Threat Hunting Security Solution Threat Hunting Team label Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@MadameSheema MadameSheema added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 25, 2021
@MadameSheema
Copy link
Member

Found during BC2 regression https://github.com/elastic/security-team/issues/843

@andrew-goldstein
Copy link
Contributor

This issue is the result of a breaking change in EUI, via this PR: elastic/eui#4480

The behavior of EuiModal has changed such that it's no longer necessary to wrap the modal in an EuiOverlayMask, because the mask is now built-in to EuiModal.

The breaking change became effective throughout Kibana when it was upgraded to use a newer version of EUI via this commit on Feb 16.

I'll put up a PR today that removes the now-redundant EuiOverlayMask, which will resolve the issue.

andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this issue Mar 1, 2021
@andrew-goldstein
## [Security Solution] Fixes the Customize Event Renderers modal by r…
72b3d76 
…emoving the EuiOverlayMask

Fixes [this issue](elastic#92798), introduced when [the EUI modal implementation changed](elastic/eui#4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.

The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](elastic@8126488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519).

This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:

### Before

![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)

### After

![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)

### Desk testing

Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:

- Chrome `88.0.4324.192`
- Firefox `86.0`
- Safari `14.0.3`
@andrew-goldstein andrew-goldstein mentioned this issue Mar 1, 2021
Merged
@jonathan-buttner jonathan-buttner mentioned this issue Mar 1, 2021
Closed
kqualters-elastic pushed a commit that referenced this issue Mar 2, 2021
@andrew-goldstein @kibanamachine
[Security Solution] Fixes the Customize Event Renderers modal by remo…
5a09a29 
…ving the EuiOverlayMask (#93150)

* ## [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask

Fixes [this issue](#92798), introduced when [the EUI modal implementation changed](elastic/eui#4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.

The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](8126488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519).

This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:

### Before

![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)

### After

![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)

### Desk testing

Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:

- Chrome `88.0.4324.192`
- Firefox `86.0`
- Safari `14.0.3`

* - force precommit git hooks to run

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Mar 2, 2021
@andrew-goldstein @kibanamachine @kqualters-elastic
[Security Solution] Fixes the Customize Event Renderers modal by remo…
4abdfb6 
…ving the EuiOverlayMask (elastic#93150)

* ## [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask

Fixes [this issue](elastic#92798), introduced when [the EUI modal implementation changed](elastic/eui#4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.

The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](elastic@8126488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519).

This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:

### Before

![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)

### After

![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)

### Desk testing

Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:

- Chrome `88.0.4324.192`
- Firefox `86.0`
- Safari `14.0.3`

* - force precommit git hooks to run

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Mar 2, 2021
@andrew-goldstein @kibanamachine @kqualters-elastic
[Security Solution] Fixes the Customize Event Renderers modal by remo…
f245ba4 
…ving the EuiOverlayMask (elastic#93150)

* ## [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask

Fixes [this issue](elastic#92798), introduced when [the EUI modal implementation changed](elastic/eui#4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.

The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](elastic@8126488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519).

This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:

### Before

![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)

### After

![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)

### Desk testing

Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:

- Chrome `88.0.4324.192`
- Firefox `86.0`
- Safari `14.0.3`

* - force precommit git hooks to run

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@MadameSheema
Copy link
Member

@karanbirsingh-qasource can you please validate the fix on BC3? Thanks :)

@MadameSheema MadameSheema reopened this Mar 2, 2021
@MadameSheema MadameSheema assigned ghost and unassigned andrew-goldstein Mar 2, 2021
kqualters-elastic added a commit that referenced this issue Mar 2, 2021
@kqualters-elastic @andrew-goldstein @kibanamachine
[Security Solution] Fixes the Customize Event Renderers modal by remo…
37530d7 
…ving the EuiOverlayMask (#93150) (#93213)

* ## [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask

Fixes [this issue](#92798), introduced when [the EUI modal implementation changed](elastic/eui#4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.

The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](8126488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519).

This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:

### Before

![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)

### After

![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)

### Desk testing

Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:

- Chrome `88.0.4324.192`
- Firefox `86.0`
- Safari `14.0.3`

* - force precommit git hooks to run

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Andrew Goldstein <andrew-goldstein@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kqualters-elastic added a commit that referenced this issue Mar 2, 2021
@kqualters-elastic @andrew-goldstein @kibanamachine
[Security Solution] Fixes the Customize Event Renderers modal by remo…
ed0f8eb 
…ving the EuiOverlayMask (#93150) (#93215)

* ## [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask

Fixes [this issue](#92798), introduced when [the EUI modal implementation changed](elastic/eui#4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.

The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](8126488#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519).

This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:

### Before

![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)

### After

![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)

### Desk testing

Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:

- Chrome `88.0.4324.192`
- Firefox `86.0`
- Safari `14.0.3`

* - force precommit git hooks to run

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Andrew Goldstein <andrew-goldstein@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ghost
Copy link
Author

ghost commented Mar 3, 2021

Hi @andrew-garfield101 & @MadameSheema

we have validated this issue on 7.12.0 BC3 and found that issue is still occurring . Customize event rendering page was disabled for user to perform any action.

Build Details:

Version: 7.12.0 BC3 
Platform: ON-PREM
Commit:08417cbd6c15e4c866651a7dcdfeded58845206d
Build:39134

Snap-Shoot:

  • Windows Firefox : 86.0
    image

  • Windows Chrome: 89.0.4389.72
    image

  • Mac Chrome : 89.0.4389.72
    image

  • Mac Safari : 13.1.2 (13609.3.5.1.5)
    image

thanks

@MadameSheema
Copy link
Member

Thanks @karanbirsingh-qasource the fix is done but looks like didn't arrive to BC3, can you please validate it again once BC4 is ready?

@MadameSheema
Copy link
Member

@karanbirsingh-qasource can you please prioritise the validation of this fix? thanks

@ghost
Copy link

ghost commented Mar 11, 2021

Hi @andrew-garfield101 & @MadameSheema

We have validated this issue on 7.12.0 BC4 and Observed that issue is Fixed. Customize event rendering page is enabled for the user to perform any action.

Build Details:

Version: 7.12.0-BC4
Platform: Production
Commit:99ac38d70e426f589bb61a034c96e602d759cfab
Build:39242
https://staging.elastic.co/7.12.0-336ff10d/summary-7.12.0.html

Screenshot:
Windows Firefox: 86.0
Firefox

Windows Chrome: 89.0.4389.82
chrome

Mac Chrome : 89.0.4389.82
Chrome_safari

Mac Safari : 13.1.2 (13609.3.5.1.5)
Safari_mac

Hence, We are closing this ticket

Thanks!!

@ghost ghost closed this as completed Mar 11, 2021
@ghost ghost added the QA:Validated Issue has been validated by QA label Mar 11, 2021
@ghost
Copy link

ghost commented Mar 26, 2021 •
edited by ghost
Loading

Bug Conversion:

Test case already exist for this ticket:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0
Projects
None yet
Milestone
No milestone
4 participants
@andrew-goldstein @elasticmachine @MadameSheema @manishgupta-qasource