Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing use_null setting in advanced job wizard #100028

Merged
merged 5 commits into from
May 17, 2021
Merged

[ML] Fixing use_null setting in advanced job wizard #100028

merged 5 commits into from
May 17, 2021

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented May 13, 2021 •
edited
Loading

Fixes issue where the use_null setting in a detector isn't expected in the job creator class and so is ignored if a user enters one manually through the JSON editor.

Fixes #100026

@jgowdyelastic jgowdyelastic mentioned this pull request May 13, 2021
Closed
@jgowdyelastic jgowdyelastic self-assigned this May 17, 2021
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection release_note:fix review v7.14.0 v8.0.0 labels May 17, 2021
@jgowdyelastic jgowdyelastic marked this pull request as ready for review May 17, 2021 09:47
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner May 17, 2021 09:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

peteharverson
peteharverson approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Member

qn895 commented May 17, 2021

LGTM 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +461.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic added the auto-backport Deprecated - use backport:version if exact versions are needed label May 17, 2021
@jgowdyelastic jgowdyelastic merged commit 7f9364a into elastic:master May 17, 2021
@jgowdyelastic jgowdyelastic deleted the fixing-use-null-setting-in-advanced-job-wizard branch May 17, 2021 20:04
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 17, 2021
@jgowdyelastic @kibanamachine
[ML] Fixing use_null setting in advanced job wizard (elastic#100028)
44a2ae7 
* [ML] Fixing use_null setting in advanced job wizard

* fixing types

* fixing false checks for detector fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request May 17, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 17, 2021
@kibanamachine @jgowdyelastic
[ML] Fixing use_null setting in advanced job wizard (#100028) (#100239)
7c6b5b4 
* [ML] Fixing use_null setting in advanced job wizard

* fixing types

* fixing false checks for detector fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@jgowdyelastic @kibanamachine @yctercero
[ML] Fixing use_null setting in advanced job wizard (elastic#100028)
125d587 
* [ML] Fixing use_null setting in advanced job wizard

* fixing types

* fixing false checks for detector fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] use_null is not cloned for anomaly detection job
5 participants
@jgowdyelastic @elasticmachine @qn895 @kibanamachine @peteharverson