Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Replace side nav with tabs on Settings page #101460

Merged
merged 7 commits into from
Jun 9, 2021
Merged

[APM] Replace side nav with tabs on Settings page #101460

merged 7 commits into from
Jun 9, 2021

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Jun 7, 2021 •
edited
Loading

Closes #101384

image

image

image

image

@sorenlouv sorenlouv changed the title [APM] Make page full height [APM] Replace side nav with tabs on Settings page Jun 7, 2021
@sorenlouv sorenlouv marked this pull request as ready for review June 7, 2021 17:37
@sorenlouv sorenlouv requested a review from a team as a code owner June 7, 2021 17:37
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

formgeist
formgeist approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few minor fixes to the labels and striking a title from the configuration template

.../app/Settings/AgentConfigurations/AgentConfigurationCreateEdit/SettingsPage/SettingsPage.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/routing/templates/settings_template.tsx Outdated Show resolved Hide resolved
sorenlouv and others added 2 commits June 9, 2021 10:23
@sorenlouv @formgeist
Revert Settings title
62123d8 
Co-authored-by: Casper Hübertz <casper@formgeist.com>
@sorenlouv
Remove redundant title
d073984
@sorenlouv sorenlouv enabled auto-merge (squash) June 9, 2021 08:26
@sorenlouv sorenlouv added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB -4.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 8b555c7 into elastic:master Jun 9, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 101460

@sorenlouv sorenlouv deleted the add-tabs-to-settings branch June 9, 2021 13:02
@sorenlouv sorenlouv removed the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 9, 2021
@sorenlouv sorenlouv mentioned this pull request Jun 9, 2021
Merged
sorenlouv added a commit that referenced this pull request Jun 9, 2021
@sorenlouv @formgeist
[APM] Replace side nav with tabs on Settings page (#101460) (#101803)
5f01e72 
Co-authored-by: Casper Hübertz <casper@formgeist.com>

Co-authored-by: Casper Hübertz <casper@formgeist.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
53e584b 
* master:
  clarify which parts of TM are experimental (elastic#101757)
  Add sh scripts with _bulk_action route usage examples (elastic#101736)
  [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709)
  Use KIBANA_DOCS in doc link service (elastic#101667)
  [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387)
  Address design issues in Discover/Graph (elastic#101584)
  Optimize performance for document table (elastic#101715)
  Change file data visualizer links to point to new location in home application (elastic#101393)
  [Fleet] Tighten policy permissions, take II (elastic#97366)
  [ML] Add debounce to the severity control update  (elastic#101581)
  [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658)
  [APM] Add link-to/transaction route (elastic#101731)
  [Index Patterns] Runtime fields CRUD REST API  (elastic#101164)
  [ILM] Refactor types and fix missing aria labels (elastic#101518)
  [Lens] New summary row feature for datatable (elastic#101075)
  Blocks save event filter with a white space name (elastic#101599)
  Improve security server types (elastic#101661)
  [APM] Replace side nav with tabs on Settings page (elastic#101460)
  [APM] Only register items in side nav if user has permissions to see app (elastic#101707)
  [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist approved these changes

Assignees
No one assigned
Labels
release_note:enhancement Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Move Settings navigation to the PageHeader tabs
4 participants
@sorenlouv @elasticmachine @kibanamachine @formgeist