Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add Windows and macOs option to dropdown for creating Exceptions from scratch #103404

Merged

Conversation

kevinlog
Copy link
Contributor

Summary

This PR introduces a dropdown option for OS in Exceptions to allow users to create an Exception for both Mac and Windows in one go. This is meant to preserve previous functionality where creating Exceptions from scratch always added the Exception to both Mac and Windows.

It addresses #102613

New Dropdown options:
image

Selecting Windows and macOs properly gives user the correct *.caseless options
image

Saved Exception for Mac and Windows:
image

Editing an Exception for Mac and Windows:
image

Linux only options still has options without *.caseless:
image

Creating Exceptions from Alerts still works as expected:
image

Checklist

Delete any items that are not applicable to this PR.

@kevinlog kevinlog added v8.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 release_note:feature Makes this part of the condensed release notes labels Jun 25, 2021
@kevinlog kevinlog requested a review from a team as a code owner June 25, 2021 17:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.2MB 6.2MB +360.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Kevin!

@kevinlog kevinlog added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 28, 2021
@kevinlog kevinlog merged commit 73919aa into elastic:master Jun 28, 2021
@kevinlog kevinlog deleted the bug/support-mac-and-windows-selection branch June 28, 2021 18:23
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 28, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 28, 2021
…ting Exceptions from scratch (#103404) (#103529)

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:feature Makes this part of the condensed release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants