Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Fix default naming and sorting fields suggestion for top_metrics agg #103690

Merged
merged 7 commits into from Jun 30, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jun 29, 2021

Summary

Resolves #103455

Checklist

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.14.0 labels Jun 29, 2021
@darnautov darnautov self-assigned this Jun 29, 2021
@darnautov darnautov requested a review from a team as a code owner June 29, 2021 15:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 928.4KB 927.6KB -842.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit a63084b into elastic:master Jun 30, 2021
@darnautov darnautov added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jun 30, 2021
@darnautov darnautov deleted the transform-103455-fix-top-metrics branch June 30, 2021 10:53
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2021
…_metrics` agg (elastic#103690)

* [ML] remove advanced settings

* [ML] fix getUpdatedItem for switching to single field agg

* [ML] incremental naming for top aggs

* [ML] set default sorting field based on date type

* [ML] set desc order by default

* [ML] fix TS

* [ML] change sorting direction init
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 30, 2021
…_metrics` agg (#103690) (#103862)

* [ML] remove advanced settings

* [ML] fix getUpdatedItem for switching to single field agg

* [ML] incremental naming for top aggs

* [ML] set default sorting field based on date type

* [ML] set desc order by default

* [ML] fix TS

* [ML] change sorting direction init

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
…-policy-2

* 'master' of github.com:elastic/kibana:
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)

# Conflicts:
#	x-pack/plugins/reporting/server/lib/store/store.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
@spalger spalger added the v7.15.0 label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transforms] top_metrics UI feedback
5 participants