Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v31.0.0 (master) #102078

Merged
merged 1 commit into from Jun 30, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 14, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 30.1.0 -> 31.0.0 age adoption passing confidence

Release Notes

elastic/elastic-charts

31.0.0 (2021-06-29)

Bug Fixes

Features

  • annotations: option to render rect annotations outside chart (#1207) (4eda382)
  • heatmap: enable brushing on categorical charts (#1212) (10c3493), closes #1170 #1171
  • xy: add onPointerUpdate debounce and trigger options (#1194) (a9a9b25)

BREAKING CHANGES

  • xy: the PointerOverEvent type now extends ProjectedValues and drops value. This effectively replaces value with x, y, smVerticalValue and smHorizontalValue.

30.2.0 (2021-06-10)

Features

  • a11y: add data table for screen readers (sunburst, treemap, icicle, flame) (#1155) (87fd75f), closes #1154

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels Jun 14, 2021
@renovate renovate bot requested review from markov00 and nickofthyme June 14, 2021 14:55
@markov00
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@markov00 markov00 added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jun 15, 2021
@renovate renovate bot force-pushed the renovate/master-@elasticcharts branch from f25a982 to 871c175 Compare June 22, 2021 00:03
@renovate renovate bot force-pushed the renovate/master-@elasticcharts branch from 871c175 to 5019a14 Compare June 29, 2021 05:49
@markov00 markov00 changed the title Update dependency @elastic/charts to v30.2.0 (master) Update dependency @elastic/charts to v31.0.0 (master) Jun 29, 2021
@markov00
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 417.7KB 419.2KB +1.5KB
kbnUiSharedDeps-elastic 2.6MB 2.6MB -1.6KB
kbnUiSharedDeps-js 6.4MB 6.4MB +455.0B
total +375.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the breaking changes reported in elastic/elastic-charts#1194 and relative to the onPointerUpdate listener used on the <Settings /> component in Charts does not affect the current Kibana implementation.
I've checked the listener use across Kibana: is used only to sync the cursors/tooltip between charts. I haven't found a case where the PointerEvent is used directly.

I'd like to ping few team members to review the changes on the possible affected charts:

  • @sqren for x-pack/plugins/apm/public/components/shared/charts/transaction_breakdown_chart/transaction_breakdown_chart_contents.tsx
  • @stratoula for src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js
  • @phillipb for x-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/metrics/chart_section.tsx and x-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/metrics/metrics.tsx

The way to review is to check your affected components and verify that the cursor/tooltip is correctly synched across multiple charts

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSVB doesn't seem to be affected by this change

@markov00 markov00 merged commit 345b938 into master Jun 30, 2021
@renovate renovate bot deleted the renovate/master-@elasticcharts branch June 30, 2021 07:13
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 30, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
@spalger spalger added the v7.15.0 label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0
Projects
None yet
6 participants