New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover][Search Sessions] force pause refresh when restoring discover state #105743
[Discover][Search Sessions] force pause refresh when restoring discover state #105743
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested saving and restoring a search session in Chrome with an active refresh interval. it's no longer active when the session is restored
💚 Build SucceededMetrics [docs]Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Summary
Fixes #104449
Problem is that when restoring a search session, auto-refresh might be turned on (in memory inside time filter service) causing navigation away from a restored session. And we don't want that.
Fix similar to how it is handled in Dashboard:
kibana/src/plugins/dashboard/public/application/lib/dashboard_session_restoration.ts
Lines 124 to 130 in 5fcdb9d
Fix will only be applied to newly created sessions
Checklist