Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search session][Discover] Clear refresh interval when restoring search session #106249

Conversation

jloleysens
Copy link
Contributor

Summary

Per title

Closes #104449

Screenshot after restoring a search session

Screenshot 2021-07-20 at 15 27 39

Checklist

@jloleysens jloleysens added Feature:Discover Discover Application v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated: Automatically backport this PR after it's merged v7.15.0 v7.14.1 labels Jul 20, 2021
@jloleysens jloleysens requested review from Dosant and a team July 20, 2021 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@jloleysens jloleysens changed the title [Search session][Discover] Clear refresh interval when restoring session [Search session][Discover] Clear refresh interval when restoring search session Jul 20, 2021
@Dosant
Copy link
Contributor

Dosant commented Jul 20, 2021

😮 same as? #105743
sorry for a bit of double work

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 425.1KB 425.2KB +69.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@Dosant I didn't spot the linked pull request further down on the issue. I'll close this and review yours!

@jloleysens jloleysens closed this Jul 21, 2021
@jloleysens jloleysens deleted the searchsessions/fix-clear-refreshInterval-on-restore branch July 21, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search Sessions] Discover restored session auto refreshes
4 participants