[Maps] implemention of usng support fixing #76144 #107835

mkellogg91 · 2021-08-06T15:00:14Z

Summary

Adds usng.js library for Lat Lon, UTM, and MGRS conversion instead of using MGRS and UTM libraries. Fix and images of UI shown in #76144.

Release note

Adds support for UTM and MGRS coordinates in Maps "Go To" button.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2021-08-06T15:00:16Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

mkellogg91 · 2021-08-06T15:22:23Z

@nickpeihl @nreese didn't add the "review" label to the pr before it was created and am unsure how to add it now.

elasticmachine · 2021-08-06T15:25:11Z

Pinging @elastic/kibana-gis (Team:Geo)

nickpeihl · 2021-08-06T15:29:47Z

Hi @mkellogg91. Thanks for the PR. We'll handle the labels.

@elasticmachine test this please

mkellogg91 · 2021-08-09T16:13:29Z

@nickpeihl anything further required from me, or just waiting on approval?

nickpeihl

Thanks for contributing @mkellogg91.

In addition to my inline comments, there are some linting and typing issues that need to be resolved for our tests to pass.

Lint errors. Probably many of these can be fixed automatically by running node scripts/eslint "x-pack/**/set_view_control.tsx" --fix.
Type checks need to be resolved. You can also run type checking locally by running node scripts/type_check.js --project="x-pack/plugins/maps/tsconfig.json"
We need to pull master into your branch.

> git pull upstream master
> git push

...ugins/maps/public/connected_components/toolbar_overlay/set_view_control/set_view_control.tsx

cla-checker-service · 2021-08-13T18:07:46Z

💚 CLA has been signed

nickpeihl · 2021-08-16T15:11:32Z

Hi @mkellogg91. Can you please sign the Contributor Agreement linked above? We can not merge this PR without it. Thanks.

thomasneirynck

this is great.

@mkellogg91 if you sign the CLA, Kibana's CI will run the test suite.

I also put some initial version labels on this, a requirement for CI to be green.

Just a few nits from my end. See comments

Also, just so i understand, but should changing the UTM-zone, also not shift the location of the center?

...ugins/maps/public/connected_components/toolbar_overlay/set_view_control/set_view_control.tsx

mkellogg91 · 2021-08-23T13:08:54Z

Hi @mkellogg91. Can you please sign the Contributor Agreement linked above? We can not merge this PR without it. Thanks.

Signed. Was out for a week, but have returned now and will work on getting all the requested changes above completed

…fix-76144-add-usng-support

mkellogg91 · 2021-08-24T18:19:21Z

@nickpeihl I've submitted changes according to your requests. Take a look and let me know what you think

mkellogg91 · 2021-08-26T14:29:43Z

this is great.

@mkellogg91 if you sign the CLA, Kibana's CI will run the test suite.

I also put some initial version labels on this, a requirement for CI to be green.

Just a few nits from my end. See comments

Also, just so i understand, but should changing the UTM-zone, also not shift the location of the center?

this was a good catch. It wasn't working properly before. you should find that it works now

nickpeihl

Thanks for the fixes @mkellogg91. I added some suggestions I think we can use to avoid using the any type. But please verify that my suggestions are accurate.

...ugins/maps/public/connected_components/toolbar_overlay/set_view_control/set_view_control.tsx

…fix-76144-add-usng-support

nickpeihl · 2021-09-08T17:13:13Z

Hi @mkellogg91. This is looking good.

Would you mind enabling allow edits from maintainers on this PR? It will help us keep the master branch in sync and keep CI running.
Can you also take a look at this suggestion by @thomasneirynck?

Once we address those two items, I think we can merge.

mkellogg91 · 2021-09-08T18:06:30Z

Hi @mkellogg91. This is looking good.

1. Would you mind enabling [allow edits from maintainers](https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) on this PR? It will help us keep the master branch in sync and keep CI running.

2. Can you also take a look at [this suggestion by @thomasneirynck](https://github.com/elastic/kibana/pull/107835#discussion_r691596953)?

Once we address those two items, I think we can merge.

@nickpeihl I do not see this option in the pull request...is it possible I don't have permission to do this?

nickpeihl · 2021-09-08T18:13:24Z

@nickpeihl I do not see this option in the pull request...is it possible I don't have permission to do this?

Weird. On PRs I create there is an option on the right sidebar that looks like this. If it's there, please make sure the box is checked.

If it isn't there for you, I wonder if you have a permissions issue with the branch in the spetriclabs fork?

mkellogg91 · 2021-09-08T18:28:28Z

Hi @mkellogg91. Thanks for the PR. We'll handle the labels.

@elasticmachine test this please

nickpeihl · 2021-09-08T18:39:43Z

Hmm, in that case, you will need to keep the PR branch in sync with master since we can't do that. If you have elastic/kibana as the upstream remote, then you should just be able to:

> git pull upstream master
> git push

So please address this suggestion and pull the changes from the master branch. Then I'll trigger the CI to run and hopefully we can merge.

mkellogg91 · 2021-09-08T18:41:28Z

Hmm, in that case, you will need to keep the PR branch in sync with master since we can't do that. If you have elastic/kibana as the upstream remote, then you should just be able to:
> git pull upstream master
> git push
So please address this suggestion and pull the changes from the master branch. Then I'll trigger the CI to run and hopefully we can merge.

Will do..I'll work on addressing that suggestion.

…fix-76144-add-usng-support

mkellogg91 · 2021-09-08T19:26:07Z

@nickpeihl just pushed changes for unused code paths and pulled in upstream changes from master

nickpeihl · 2021-09-08T19:27:13Z

Jenkins, test this

nickpeihl · 2021-09-08T21:04:01Z

@mkellogg91 looks like we're seeing some lint errors. Can you run node scripts/eslint "x-pack/**/set_view_control.tsx" --fix again to see if that fixes them?

…fix-76144-add-usng-support

mkellogg91 · 2021-09-09T13:26:34Z

@mkellogg91 looks like we're seeing some lint errors. Can you run node scripts/eslint "x-pack/**/set_view_control.tsx" --fix again to see if that fixes them?

Fixed linting issues and pulled upstream master, then pushed changes again to feature branch.

nickpeihl · 2021-09-09T15:49:39Z

jenkins, test this

mkellogg91 · 2021-09-09T16:00:21Z

jenkins, test this

after this PR makes it in I'm going to put "Official ElasticSearch and Kibana Git Contributer" on my linkedin and be showered with cash

kibanamachine · 2021-09-09T17:53:16Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`maps`	846	847	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	3.2MB	3.2MB	+30.7KB

History

💔 Build #151992 failed 891ddde
💔 Build #143470 failed b496221

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl

lgtm!

code review and tested in firefox.

Thanks @mkellogg91 for your contribution to Kibana!

) * implemention of usng support fixing elastic#76144 * linting fixes * lint fixes * pr code edits * fixed utm zone and added error proofing * removing any data types and replacing with explicit ones * avoiding render of unused components * fixing linting issues Co-authored-by: Michael Ihde <mihde@spectric.com>

kibanamachine · 2021-09-09T21:54:58Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* implemention of usng support fixing #76144 * linting fixes * lint fixes * pr code edits * fixed utm zone and added error proofing * removing any data types and replacing with explicit ones * avoiding render of unused components * fixing linting issues Co-authored-by: Michael Ihde <mihde@spectric.com> Co-authored-by: Michael Kellogg <mkellogg91@gmail.com> Co-authored-by: Michael Ihde <mihde@spectric.com>

implemention of usng support fixing elastic#76144

b496221

kibanamachine added the 💝community label Aug 6, 2021

nickpeihl added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Aug 6, 2021

thomasneirynck requested review from thomasneirynck and nickpeihl August 9, 2021 18:40

thomasneirynck changed the title ~~implemention of usng support fixing #76144~~ [Maps] implemention of usng support fixing #76144 Aug 9, 2021

nickpeihl requested changes Aug 10, 2021

View reviewed changes

mkellogg91 added 2 commits August 12, 2021 11:57

linting fixes

4657a42

lint fixes

27a3b99

mkellogg91 requested a review from a team as a code owner August 13, 2021 18:07

thomasneirynck added v6.8.0 v7.16.0 release_note:enhancement labels Aug 18, 2021

thomasneirynck reviewed Aug 18, 2021

View reviewed changes

mkellogg91 added 3 commits August 23, 2021 09:58

Merge branch 'master' of https://github.com/elastic/kibana into feat-…

d4ea620

…fix-76144-add-usng-support

pr code edits

3589d72

fixed utm zone and added error proofing

6e698d9

nickpeihl reviewed Aug 30, 2021

View reviewed changes

mkellogg91 added 2 commits September 3, 2021 11:46

removing any data types and replacing with explicit ones

8bdff0b

Merge branch 'master' of https://github.com/elastic/kibana into feat-…

476d202

…fix-76144-add-usng-support

mkellogg91 marked this pull request as draft September 8, 2021 18:00

mkellogg91 marked this pull request as ready for review September 8, 2021 18:01

mkellogg91 added 2 commits September 8, 2021 15:23

avoiding render of unused components

b3dd524

Merge branch 'master' of https://github.com/elastic/kibana into feat-…

891ddde

…fix-76144-add-usng-support

mkellogg91 added 2 commits September 9, 2021 09:24

Merge branch 'master' of https://github.com/elastic/kibana into feat-…

370a286

…fix-76144-add-usng-support

fixing linting issues

13cb390

nickpeihl self-requested a review September 9, 2021 21:26

nickpeihl approved these changes Sep 9, 2021

View reviewed changes

nickpeihl self-requested a review September 9, 2021 21:33

nickpeihl approved these changes Sep 9, 2021

View reviewed changes

nickpeihl added the auto-backport Deprecated: Automatically backport this PR after it's merged label Sep 9, 2021

nickpeihl merged commit 5acd132 into elastic:master Sep 9, 2021

kibanamachine mentioned this pull request Sep 9, 2021

[7.x] [Maps] implemention of usng support fixing #76144 (#107835) #111807

Merged

nickpeihl mentioned this pull request Sep 9, 2021

[Maps] Support UTM and MGRS in Maps #76144

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] implemention of usng support fixing #76144 #107835

[Maps] implemention of usng support fixing #76144 #107835

mkellogg91 commented Aug 6, 2021 •

edited by timroes

Loading

kibanamachine commented Aug 6, 2021

mkellogg91 commented Aug 6, 2021 •

edited

Loading

elasticmachine commented Aug 6, 2021

nickpeihl commented Aug 6, 2021 •

edited

Loading

mkellogg91 commented Aug 9, 2021

nickpeihl left a comment

cla-checker-service bot commented Aug 13, 2021 •

edited

Loading

nickpeihl commented Aug 16, 2021 •

edited

Loading

thomasneirynck left a comment •

edited

Loading

mkellogg91 commented Aug 23, 2021

mkellogg91 commented Aug 24, 2021

mkellogg91 commented Aug 26, 2021

nickpeihl left a comment

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021 •

edited

Loading

nickpeihl commented Sep 8, 2021

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 9, 2021

nickpeihl commented Sep 9, 2021

mkellogg91 commented Sep 9, 2021

kibanamachine commented Sep 9, 2021

nickpeihl left a comment

kibanamachine commented Sep 9, 2021

[Maps] implemention of usng support fixing #76144 #107835

[Maps] implemention of usng support fixing #76144 #107835

Conversation

mkellogg91 commented Aug 6, 2021 • edited by timroes Loading

Summary

Release note

Checklist

For maintainers

kibanamachine commented Aug 6, 2021

mkellogg91 commented Aug 6, 2021 • edited Loading

elasticmachine commented Aug 6, 2021

nickpeihl commented Aug 6, 2021 • edited Loading

mkellogg91 commented Aug 9, 2021

nickpeihl left a comment

Choose a reason for hiding this comment

cla-checker-service bot commented Aug 13, 2021 • edited Loading

nickpeihl commented Aug 16, 2021 • edited Loading

thomasneirynck left a comment • edited Loading

Choose a reason for hiding this comment

mkellogg91 commented Aug 23, 2021

mkellogg91 commented Aug 24, 2021

mkellogg91 commented Aug 26, 2021

nickpeihl left a comment

Choose a reason for hiding this comment

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021

mkellogg91 commented Sep 8, 2021 • edited Loading

nickpeihl commented Sep 8, 2021

nickpeihl commented Sep 8, 2021

mkellogg91 commented Sep 9, 2021

nickpeihl commented Sep 9, 2021

mkellogg91 commented Sep 9, 2021

kibanamachine commented Sep 9, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

nickpeihl left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 9, 2021

💚 Backport successful

mkellogg91 commented Aug 6, 2021 •

edited by timroes

Loading

mkellogg91 commented Aug 6, 2021 •

edited

Loading

nickpeihl commented Aug 6, 2021 •

edited

Loading

cla-checker-service bot commented Aug 13, 2021 •

edited

Loading

nickpeihl commented Aug 16, 2021 •

edited

Loading

thomasneirynck left a comment •

edited

Loading

mkellogg91 commented Sep 8, 2021 •

edited

Loading