Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Support UTM and MGRS in Maps #76144

Closed
maihde opened this issue Aug 27, 2020 · 10 comments
Closed

[Maps] Support UTM and MGRS in Maps #76144

maihde opened this issue Aug 27, 2020 · 10 comments
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result
Projects

Comments

@maihde
Copy link
Contributor

maihde commented Aug 27, 2020

Describe the feature: Currently the Maps "Go To" button only supports Degrees Decimal format. For many users it would be convenient to be able to also use UTM or MGRS coordinates.

Describe a specific use case for the feature: Users who use MGRS or UTM to perform geospatial analysis.

I have implemented a prototype:
image
image
image
image

spectriclabs@9fb93d8

@myasonik myasonik added enhancement New value added to drive a business result [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Aug 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor

nreese commented Aug 28, 2020

How often do users switch between decimal degrees, UTM, and MGRS? Would it make sense to move this setting to a map wide setting that would also effect the coordinates displayed in the lower right corner?

@maihde
Copy link
Contributor Author

maihde commented Aug 28, 2020

@nreese I'll have to ask the users; my experience is that it changes based somewhat arbitrarily based off the source of the coordinates. In other words, I have a map that I use for analysis, and sometimes I get a UTM coordinate to look at and sometimes I get a Degrees Decimal, and sometimes I get MGRS.

That said, I think that if would be fine for the coordinate setting in the "Go To" to also affect the display in the lower right corner. I just wouldn't want the coordinate setting to be a global setting across all users or be buried somewhere that makes it annoying for the user to change.

@thomasneirynck thomasneirynck added this to Backlog in Maps Sep 1, 2020
@thomasneirynck thomasneirynck changed the title Support UTM and MGRS in Maps [Maps] Support UTM and MGRS in Maps Sep 1, 2020
@jsanz
Copy link
Member

jsanz commented Sep 1, 2020

@maihde I see from your code that utm and mgrs packages work only on WGS84 ellipsoid. Are you expecting to support other datums like NAD27 or from other parts of the world?

What about supporting other projections like Albers (EPSG:5070) or Lambert Conformal Conic (EPSG:26953)?

@nickpeihl
Copy link
Member

The fuzziness of the license of the mgrs package worries me a little bit. Are the licensed code bits in that package compatible with our license?

@kmartastic
Copy link
Contributor

I like the idea of using coordinate inputs for navigation and to display coordinates on the map per user preference.

The existing Go To UI is OK.

I think an improvement to this experience would be to use a single-search bar to navigate/search a map.

User can easily copy/paste coordinates into the search bar and hit enter/return/go. No configuration required.

i.e.
17N 630084 4833438
4QFJ 12345 67890
43.6532° N, 79.3832° W
43.65, -5.02

In the future, the search would expand to allow for navigate to documents on the map; or common places via a simple forward geocoder.

@nickpeihl
Copy link
Member

The fuzziness of the license of the mgrs package worries me a little bit. Are the licensed code bits in that package compatible with our license?

After further review, I recommend we use https://github.com/codice/usng.js instead of the mgrs library. The license of usng.js is more definite and it supports conversion to UTM and MGRS.

@maihde
Copy link
Contributor Author

maihde commented May 24, 2021

@nickpeihl would it help to get this into the baseline sooner if I submit a PR of this using the usng library?

@kmartastic I like the concept you propose a lot! My only concern is that such a large change would mean that it will take longer for UTM/MGRS support to be available in the map. It's a relatively simple change to use the existing UI paradigm now.
Later the 'Go To' can evolved as you describe.

@jsanz my users only really care about WGS84.

@nickpeihl
Copy link
Member

Hi @maihde. I don't believe anyone is currently working on this feature, so I think it may help if you submit a PR. I agree with you on making small changes first and supporting additional features later.

mkellogg91 pushed a commit to spectriclabs/kibana that referenced this issue Aug 5, 2021
mkellogg91 pushed a commit to spectriclabs/kibana that referenced this issue Aug 5, 2021
mkellogg91 pushed a commit to spectriclabs/kibana that referenced this issue Aug 6, 2021
nickpeihl pushed a commit that referenced this issue Sep 9, 2021
* implemention of usng support fixing #76144

* linting fixes

* lint fixes

* pr code edits

* fixed utm zone and added error proofing

* removing any data types and replacing with explicit ones

* avoiding render of unused components

* fixing linting issues

Co-authored-by: Michael Ihde <mihde@spectric.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 9, 2021
)

* implemention of usng support fixing elastic#76144

* linting fixes

* lint fixes

* pr code edits

* fixed utm zone and added error proofing

* removing any data types and replacing with explicit ones

* avoiding render of unused components

* fixing linting issues

Co-authored-by: Michael Ihde <mihde@spectric.com>
@nickpeihl
Copy link
Member

Fixed by #107835

kibanamachine added a commit that referenced this issue Sep 10, 2021
* implemention of usng support fixing #76144

* linting fixes

* lint fixes

* pr code edits

* fixed utm zone and added error proofing

* removing any data types and replacing with explicit ones

* avoiding render of unused components

* fixing linting issues

Co-authored-by: Michael Ihde <mihde@spectric.com>

Co-authored-by: Michael Kellogg <mkellogg91@gmail.com>
Co-authored-by: Michael Ihde <mihde@spectric.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result
Projects
No open projects
Maps
  
Backlog
Development

No branches or pull requests

7 participants