Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Accessibility] Take into account background color for non opaque colors #107877

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Aug 9, 2021

Summary

Fixes #106593

Color contrast now takes into account also EUI background color when computing final text color for the datatable dynamic coloring.

a11y_test_color

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 9, 2021
@dej611 dej611 requested a review from a team August 9, 2021 10:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB +385.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the app and in canvas. Code LGTM.

@dej611 dej611 merged commit 778a116 into elastic:master Aug 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2021
…ue colors (elastic#107877)

* 🐛 Take into account also background color if opaque

* ✅ Add tests for opaque colors
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 10, 2021
…ue colors (#107877) (#108011)

* 🐛 Take into account also background color if opaque

* ✅ Add tests for opaque colors

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Table Cell Color Opacity Not Taken Into Account
4 participants