Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] [Security Solution] Update Alert page header style #108359

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[RAC] [Security Solution] Update Alert page header style #108359

merged 1 commit into from
Aug 12, 2021

Conversation

machadoum
Copy link
Member

Summary

Update the Alert Header to meet the below style requirements:

issue: #107909
For reference: #106585

Current:
image

Update:
Screenshot 2021-08-12 at 14 01 06

  • Remove gear icon from Rules button
  • Change text of Rules button to 'Manage rules'
  • Change to empty button
  • Remove 'Last alert...' timestamp

@machadoum machadoum added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 12, 2021
@machadoum machadoum self-assigned this Aug 12, 2021
@machadoum machadoum requested a review from a team as a code owner August 12, 2021 12:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum changed the title [RAC][Security Solution] Update Alert page header style [RAC] [Security Solution] Update Alert page header style Aug 12, 2021
michaelolo24
michaelolo24 approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@machadoum machadoum enabled auto-merge (squash) August 12, 2021 13:35
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB -255.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit f498b7a into elastic:master Aug 12, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 12, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 12, 2021
@machadoum @kibanamachine
Update Alert page header style (elastic#108359)
e691e80
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 12, 2021
@kibanamachine @machadoum
Update Alert page header style (#108359) (#108380)
f268321 
Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@machadoum machadoum

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@machadoum @elasticmachine @kibanamachine @michaelolo24