Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true #10855

Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 22, 2017

Closes #8449

Kibana requires that elasticsearch support specifying the index name for each request in an mget/msearch/bulk request, and to help admins understand this requirement it has been added to the elasticsearch health checks.

image

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit da74036 into elastic:master Mar 24, 2017
elastic-jasper added a commit that referenced this pull request Mar 24, 2017
Backports PR #10855

**Commit 1:**
[elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* Original sha: 6752e71
* Authored by spalger <spalger@users.noreply.github.com> on 2017-03-22T21:03:00Z

**Commit 2:**
[elasticsearch/healthCheck] fix tests

* Original sha: 49b1cb4
* Authored by spalger <spalger@users.noreply.github.com> on 2017-03-22T21:49:28Z
spalger pushed a commit that referenced this pull request Mar 24, 2017
…ue (#10880)

Backports PR #10855

**Commit 1:**
[elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* Original sha: 6752e71
* Authored by spalger <spalger@users.noreply.github.com> on 2017-03-22T21:03:00Z

**Commit 2:**
[elasticsearch/healthCheck] fix tests

* Original sha: 49b1cb4
* Authored by spalger <spalger@users.noreply.github.com> on 2017-03-22T21:49:28Z
simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Mar 27, 2017
…ue (elastic#10855)

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* [elasticsearch/healthCheck] fix tests
simianhacker added a commit that referenced this pull request Mar 28, 2017
…#10890)

* Removing derivative behavior... adding better tooltips to add delete

* Re-organizing metrics; Adding headers; Adding default behavoir

* Adding help text

* Additional fixes

- Fix for deactivated still being able to be added
- Added Experimental Feature to description

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true (#10855)

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* [elasticsearch/healthCheck] fix tests

* [eslint/console] enable no-undef rule (#10881)

* [eslint/console] enable no-undef rule

* [eslint/console] fix no-undef violations

* Navbarextensions improvements (#9871)

* - added controller option
- added $location service to determine on which the user is at currently

* added test for the hideButton method that is dependent on the location path

* removed  argument

* use locals object to pass variables to the template's scope

* use map object

* fixing percentage mode extents (#10843)

* fixes axis title for new axis (#10866)

* fixes metrics options matching (#10865)

* Add kuiLocalTab-isDisabled state. (#10830)

* Add kuiLocalTab-isDisabled state.

* Update Management header to use kuiLocalTab-isDisabled class.

* test: send content-type with proxy POST tests (#10903)

Elasticsearch now requires that content-type be sent on all requests
with payloads, so our tests should be sending it with requests as well.

* [esArchiver] combine elasticDump and ScenarioManager (#10359)

* As a part of bringing functional testing to plugins, esArchiver gives these plugins a way to capture and reload es indexes without needing to write a bunch of custom code. It works similarly to the elasticDump and ScenarioManager tools that it replaces.

Differences:
  - Streaming implementation allows for much larger archives
  - CLI for creating and using archives
  - Configurable archive location
  - Stores the data in gzipped files (better for source control, searching, large archives)
  - Automatically identifies and upgrades Kibana config documents

Methods:
  - `#load(name)`: import an archive
  - `#loadIfNeeded(name)`: import an archive, but skip the documents what belong to any existing index
  - `#unload(name)`: delete the indexes stored in an archive

CLI operations:
  - `./bin/es_archiver save <name> [index patterns...]`: save the mapping and documents in one or more indexes that match the wild-card patterns into an the `<name>` archive
  - `./bin/es_archiver load <name>`: load the mapping and documents from the `<name>` archive

* [functional_tests/common/nagivate] check for statusPage

* [es_archiver] move bins into new scripts dir

* [functional_tests/apps/context] use esArchiver

* [esArchiver] general improvements after showing to a few folks

 - remove auto-upgrading config doc logic (until we have better access to kibana version info)
 - export unload command
 - remove preemptive checks in favor of reacting to errors
 - use type "doc" vs "hit" for doc records (consistency)
 - wrote a bunch of pending tests to think though and plan

* [esArchiver] make log a stream that writes to itself

* [esArchiver] fill in stats and archive format tests

* [esArchiver] splitup action logic

* [esArchiver/cli] fix cli --help output and comment

* [esArchiver] remove type-based param coercion

* [esArchiver/log] use strings for log levels

* [esArchvier] remove unused var

* [esArchiver/indexDocRecordsStream] add tests

* [esArchive] fill in remaining tests

* [esArchiver] fix dem tests

* [eslint] remove unused vars

* [esArchiver/loadIfNeeded] fix call to load()

* [esArchiver] remove loadDumpData helpers
simianhacker added a commit that referenced this pull request Mar 28, 2017
…#10890)

* Removing derivative behavior... adding better tooltips to add delete

* Re-organizing metrics; Adding headers; Adding default behavoir

* Adding help text

* Additional fixes

- Fix for deactivated still being able to be added
- Added Experimental Feature to description

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true (#10855)

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* [elasticsearch/healthCheck] fix tests

* [eslint/console] enable no-undef rule (#10881)

* [eslint/console] enable no-undef rule

* [eslint/console] fix no-undef violations

* Navbarextensions improvements (#9871)

* - added controller option
- added $location service to determine on which the user is at currently

* added test for the hideButton method that is dependent on the location path

* removed  argument

* use locals object to pass variables to the template's scope

* use map object

* fixing percentage mode extents (#10843)

* fixes axis title for new axis (#10866)

* fixes metrics options matching (#10865)

* Add kuiLocalTab-isDisabled state. (#10830)

* Add kuiLocalTab-isDisabled state.

* Update Management header to use kuiLocalTab-isDisabled class.

* test: send content-type with proxy POST tests (#10903)

Elasticsearch now requires that content-type be sent on all requests
with payloads, so our tests should be sending it with requests as well.

* [esArchiver] combine elasticDump and ScenarioManager (#10359)

* As a part of bringing functional testing to plugins, esArchiver gives these plugins a way to capture and reload es indexes without needing to write a bunch of custom code. It works similarly to the elasticDump and ScenarioManager tools that it replaces.

Differences:
  - Streaming implementation allows for much larger archives
  - CLI for creating and using archives
  - Configurable archive location
  - Stores the data in gzipped files (better for source control, searching, large archives)
  - Automatically identifies and upgrades Kibana config documents

Methods:
  - `#load(name)`: import an archive
  - `#loadIfNeeded(name)`: import an archive, but skip the documents what belong to any existing index
  - `#unload(name)`: delete the indexes stored in an archive

CLI operations:
  - `./bin/es_archiver save <name> [index patterns...]`: save the mapping and documents in one or more indexes that match the wild-card patterns into an the `<name>` archive
  - `./bin/es_archiver load <name>`: load the mapping and documents from the `<name>` archive

* [functional_tests/common/nagivate] check for statusPage

* [es_archiver] move bins into new scripts dir

* [functional_tests/apps/context] use esArchiver

* [esArchiver] general improvements after showing to a few folks

 - remove auto-upgrading config doc logic (until we have better access to kibana version info)
 - export unload command
 - remove preemptive checks in favor of reacting to errors
 - use type "doc" vs "hit" for doc records (consistency)
 - wrote a bunch of pending tests to think though and plan

* [esArchiver] make log a stream that writes to itself

* [esArchiver] fill in stats and archive format tests

* [esArchiver] splitup action logic

* [esArchiver/cli] fix cli --help output and comment

* [esArchiver] remove type-based param coercion

* [esArchiver/log] use strings for log levels

* [esArchvier] remove unused var

* [esArchiver/indexDocRecordsStream] add tests

* [esArchive] fill in remaining tests

* [esArchiver] fix dem tests

* [eslint] remove unused vars

* [esArchiver/loadIfNeeded] fix call to load()

* [esArchiver] remove loadDumpData helpers
simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Mar 28, 2017
…ue (elastic#10855)

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* [elasticsearch/healthCheck] fix tests
simianhacker added a commit to simianhacker/kibana that referenced this pull request Mar 28, 2017
…elastic#10890)

* Removing derivative behavior... adding better tooltips to add delete

* Re-organizing metrics; Adding headers; Adding default behavoir

* Adding help text

* Additional fixes

- Fix for deactivated still being able to be added
- Added Experimental Feature to description

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true (elastic#10855)

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* [elasticsearch/healthCheck] fix tests

* [eslint/console] enable no-undef rule (elastic#10881)

* [eslint/console] enable no-undef rule

* [eslint/console] fix no-undef violations

* Navbarextensions improvements (elastic#9871)

* - added controller option
- added $location service to determine on which the user is at currently

* added test for the hideButton method that is dependent on the location path

* removed  argument

* use locals object to pass variables to the template's scope

* use map object

* fixing percentage mode extents (elastic#10843)

* fixes axis title for new axis (elastic#10866)

* fixes metrics options matching (elastic#10865)

* Add kuiLocalTab-isDisabled state. (elastic#10830)

* Add kuiLocalTab-isDisabled state.

* Update Management header to use kuiLocalTab-isDisabled class.

* test: send content-type with proxy POST tests (elastic#10903)

Elasticsearch now requires that content-type be sent on all requests
with payloads, so our tests should be sending it with requests as well.

* [esArchiver] combine elasticDump and ScenarioManager (elastic#10359)

* As a part of bringing functional testing to plugins, esArchiver gives these plugins a way to capture and reload es indexes without needing to write a bunch of custom code. It works similarly to the elasticDump and ScenarioManager tools that it replaces.

Differences:
  - Streaming implementation allows for much larger archives
  - CLI for creating and using archives
  - Configurable archive location
  - Stores the data in gzipped files (better for source control, searching, large archives)
  - Automatically identifies and upgrades Kibana config documents

Methods:
  - `#load(name)`: import an archive
  - `#loadIfNeeded(name)`: import an archive, but skip the documents what belong to any existing index
  - `#unload(name)`: delete the indexes stored in an archive

CLI operations:
  - `./bin/es_archiver save <name> [index patterns...]`: save the mapping and documents in one or more indexes that match the wild-card patterns into an the `<name>` archive
  - `./bin/es_archiver load <name>`: load the mapping and documents from the `<name>` archive

* [functional_tests/common/nagivate] check for statusPage

* [es_archiver] move bins into new scripts dir

* [functional_tests/apps/context] use esArchiver

* [esArchiver] general improvements after showing to a few folks

 - remove auto-upgrading config doc logic (until we have better access to kibana version info)
 - export unload command
 - remove preemptive checks in favor of reacting to errors
 - use type "doc" vs "hit" for doc records (consistency)
 - wrote a bunch of pending tests to think though and plan

* [esArchiver] make log a stream that writes to itself

* [esArchiver] fill in stats and archive format tests

* [esArchiver] splitup action logic

* [esArchiver/cli] fix cli --help output and comment

* [esArchiver] remove type-based param coercion

* [esArchiver/log] use strings for log levels

* [esArchvier] remove unused var

* [esArchiver/indexDocRecordsStream] add tests

* [esArchive] fill in remaining tests

* [esArchiver] fix dem tests

* [eslint] remove unused vars

* [esArchiver/loadIfNeeded] fix call to load()

* [esArchiver] remove loadDumpData helpers
@spalger spalger deleted the implement/ensure-es-allow-explicit-index branch August 18, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Operations Team label for Operations Team v5.4.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants