only check for url overflows when not hashing states #10878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10129
The url-overflow check ensures that the URL length doesn't get out of control and tries to warn users to use state hashing if the url is growing too long. Right now we still check the url length when the user has turned on state hashing, and since links to different states still use the unhashed state (so opening in a new tab still works, for instance) those urls trip the url-overflow check and cause Kibana to redirect to the url-overflow error page.
To prevent this I've added a check to the url-overflow check that ensures that state hashing is turned off before checking.
To reproduce this in master:
state:storeInSessionStorage
advanced configIn this PR the final step will actually render the dashboard.