Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail early on import, and don't prompt to overwrite when failing #11059

Merged
merged 3 commits into from Apr 10, 2017
Merged

Fail early on import, and don't prompt to overwrite when failing #11059

merged 3 commits into from Apr 10, 2017

Commits on Apr 5, 2017

  1. stop importing if JSON parsing fails

    @w33ble
    w33ble committed Apr 5, 2017
    Copy the full SHA
    ae85e8c View commit details
    Browse the repository at this point in the history

  2. fail early if improper JSON 

    we expect to get an array of objects, so show an error message if we find something that is not an array
    @w33ble
    w33ble committed Apr 5, 2017
    Copy the full SHA
    019f49a View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2017

  1. clarify import error message

    @w33ble
    w33ble committed Apr 6, 2017
    Copy the full SHA
    bdd4199 View commit details
    Browse the repository at this point in the history