Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Consistent "no data" screen with other Observability solutions #111630

Merged
merged 4 commits into from
Sep 9, 2021
Merged

[APM] Consistent "no data" screen with other Observability solutions #111630

merged 4 commits into from
Sep 9, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #108980

Adds logic to dynamically show the no data screen on APM.

  • A new API was created GET /api/apm/has_data which looks if there is any data available in the APM indices.
  • Removed the hasHistoricalData from the services API.
  • Removed the old empty message that was located inside the service inventory page.
  • Added API tests

When there is no data:
Screen Shot 2021-09-08 at 13 28 14

When there is data:
Screen Shot 2021-09-08 at 13 30 26

@cauemarcondes cauemarcondes added release_note:enhancement Team:APM All issues that need APM UI Team support auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 8, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner September 8, 2021 19:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

This was referenced Sep 8, 2021
Merged
Closed
@cauemarcondes cauemarcondes enabled auto-merge (squash) September 9, 2021 14:41
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1625 1626 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB -571.0B
observability 555.5KB 555.6KB +58.0B
total -513.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 9 10 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 6e9b1b5 into elastic:master Sep 9, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 9, 2021
@cauemarcondes @kibanamachine
[APM] Consistent "no data" screen with other Observability solutions (e…
bca03c7 
…lastic#111630)

* logic to show no data screen

* fixing i18n

* fixing ts

* addressing pr comments
@kibanamachine kibanamachine mentioned this pull request Sep 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@cauemarcondes cauemarcondes deleted the apm-logic-no-data-screen branch September 9, 2021 17:16
kibanamachine added a commit that referenced this pull request Sep 9, 2021
@kibanamachine @cauemarcondes
[APM] Consistent "no data" screen with other Observability solutions (#…
eab79fa 
…111630) (#111768)

* logic to show no data screen

* fixing i18n

* fixing ts

* addressing pr comments

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
@sorenlouv sorenlouv mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:APM All issues that need APM UI Team support v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Consistent "no data" screen with other Observability solutions
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv