New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the second toast when adding a new visualization straight from dashboard #11621

Merged
merged 3 commits into from May 8, 2017

Conversation

Projects
None yet
3 participants
@Stacey-Gammon
Contributor

Stacey-Gammon commented May 5, 2017

Summary: Previously using the Add new visualization button straight from dashboard caused two notifications to appear - one for successfully saving the visualization and one for successfully adding the visualization to the dashboard. Two were unnecessary and since our notifications move elements around, we will now only show the notification about successfully saving the visualization.

@nreese

nreese approved these changes May 5, 2017

LGTM

@kobelb

kobelb approved these changes May 8, 2017 edited

LGTM - pending successful CI build, looks like a related test is failing.

@Stacey-Gammon Stacey-Gammon merged commit a25d99d into elastic:master May 8, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

Stacey-Gammon added a commit to Stacey-Gammon/kibana that referenced this pull request May 8, 2017

Hide the second toast when adding a new visualization straight from d…
…ashboard (elastic#11621)

* Hide the second toast when adding a new visualization straight from dashboard

* fix tests that assume two notifications

* fix another tests that assumes two toasts

Stacey-Gammon added a commit that referenced this pull request May 8, 2017

Hide the second toast when adding a new visualization straight from d…
…ashboard (#11621) (#11650)

* Hide the second toast when adding a new visualization straight from dashboard

* fix tests that assume two notifications

* fix another tests that assumes two toasts

@Stacey-Gammon Stacey-Gammon deleted the Stacey-Gammon:hide-second-toast-dashboard branch May 8, 2017

snide added a commit to snide/kibana that referenced this pull request May 30, 2017

Hide the second toast when adding a new visualization straight from d…
…ashboard (elastic#11621)

* Hide the second toast when adding a new visualization straight from dashboard

* fix tests that assume two notifications

* fix another tests that assumes two toasts

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Hide the second toast when adding a new visualization straight from d…
…ashboard (elastic#11621) (elastic#11650)

* Hide the second toast when adding a new visualization straight from dashboard

* fix tests that assume two notifications

* fix another tests that assumes two toasts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment