Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Visualize sidebar accessibility. #11754

Merged

Conversation

Projects
None yet
3 participants
@cjcenizal
Copy link
Contributor

commented May 12, 2017

Addresses #11539

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2017

jenkins, test this

@thomasneirynck

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

hmm, CI seems to be on the fritz..

jenkins, test this

@thomasneirynck
Copy link
Contributor

left a comment

thx!

some small questions/comments.

I can't really tell when tabbing when I'm over the 'Play' and 'x'-buttons. Is this something that this PR should address as well, or is this a separate styling issue? fwiw, the orange outline makes it easy to see where you are tabbing. For example, here it is used on the expand-buttons.
image
Perhaps we can have something similar for play-and-x?

Tabbing over the play and x-buttons does not work when they are grayed-out. Is that supposed to be the case?

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2017

Thanks @thomasneirynck this is a really good point. We're going to improve visual states in a separate PRs. If you're interested, this is the issue that captures this phase of work: #11517.

CC @snide something to think about since you're working on the visual side of things right now.

@ppisljar
Copy link
Member

left a comment

LGTM

@cjcenizal cjcenizal merged commit dcc6b42 into elastic:master May 16, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:11539/visualize-sidebar-tabs-accessibility branch May 16, 2017

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request May 16, 2017

Improve Visualize sidebar accessibility. (elastic#11754)
* Make Visualize sidebar tabs keyboard accssible.
* Make Visualize Heatmap sidebar options keyboard accessible.
* Remove unnecessary kbn-accessible-click from Visualize reset button.
* Make Visualize Point Series sidebar options keyboard accessible.

cjcenizal added a commit that referenced this pull request May 16, 2017

Improve Visualize sidebar accessibility. (#11754) (#11827)
* Make Visualize sidebar tabs keyboard accssible.
* Make Visualize Heatmap sidebar options keyboard accessible.
* Remove unnecessary kbn-accessible-click from Visualize reset button.
* Make Visualize Point Series sidebar options keyboard accessible.

snide added a commit to snide/kibana that referenced this pull request May 30, 2017

Improve Visualize sidebar accessibility. (elastic#11754)
* Make Visualize sidebar tabs keyboard accssible.
* Make Visualize Heatmap sidebar options keyboard accessible.
* Remove unnecessary kbn-accessible-click from Visualize reset button.
* Make Visualize Point Series sidebar options keyboard accessible.

snide added a commit to snide/kibana that referenced this pull request Jun 2, 2017

Improve Visualize sidebar accessibility. (elastic#11754)
* Make Visualize sidebar tabs keyboard accssible.
* Make Visualize Heatmap sidebar options keyboard accessible.
* Remove unnecessary kbn-accessible-click from Visualize reset button.
* Make Visualize Point Series sidebar options keyboard accessible.

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Improve Visualize sidebar accessibility. (elastic#11754) (elastic#11827)
* Make Visualize sidebar tabs keyboard accssible.
* Make Visualize Heatmap sidebar options keyboard accessible.
* Remove unnecessary kbn-accessible-click from Visualize reset button.
* Make Visualize Point Series sidebar options keyboard accessible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.