[Cases] [104961] Remove conditional preventing additional comment field to be blank #117901

jamster10 · 2021-11-08T18:02:53Z

Issue: #104961

Summary

A conditional prevented additional comments field from being blank. The fix was to remove said conditional.

Working:

Release notes

Fix inability to clear out additional comments field in connectors.

elasticmachine · 2021-11-08T18:08:27Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2021-11-08T18:08:28Z

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

YulNaumenko

LGTM

jamster10 · 2021-11-16T17:54:04Z

@elasticmachine merge upstream

…ts-field

cnasikas

Thanks for the fix! I test all incident manager connectors and is working as expected. Code LTGM!

In the Jira connector if you add a comment and then delete it you get this error when you run the test

I think this is happening because at the begging the comment is set to undefined. Then when you type and delete the comment is set to an empty string. It seems that Jira does not accept empty comments. I think the backend should not post a comment if it is empty (only for the Jira connector)

…ts-field

…f github.com:jamster10/kibana into 104961-bug-unable-to-clear-additional-comments-field

cnasikas · 2021-11-21T09:56:38Z

x-pack/plugins/actions/server/builtin_action_types/jira/api.ts

@@ -80,6 +80,9 @@ const pushToServiceHandler = async ({
  if (comments && Array.isArray(comments) && comments.length > 0) {
    res.comments = [];
    for (const currentComment of comments) {
+      if (!currentComment.comment) {
+        break;


I think we should continue because we need the other comments to be created in the external service.

Yeah I agree with @cnasikas here, we want to continue rather than break otherwise the remaining comments will be skipped.

jonathan-buttner · 2021-11-22T14:13:19Z

x-pack/plugins/actions/server/builtin_action_types/jira/api.ts

@@ -80,6 +80,9 @@ const pushToServiceHandler = async ({
  if (comments && Array.isArray(comments) && comments.length > 0) {
    res.comments = [];
    for (const currentComment of comments) {
+      if (!currentComment.comment) {
+        break;


Yeah I agree with @cnasikas here, we want to continue rather than break otherwise the remaining comments will be skipped.

jamster10 · 2021-11-22T15:33:02Z

@elasticmachine merge upstream

…ts-field

kibana-ci · 2021-11-22T17:00:33Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	778.0KB	778.0KB	-60.0B

History

💔 Build #8188 failed 0bd73f6
💚 Build #7128 succeeded 5f26214
💛 Build #5570 was flaky 537084c
💔 Build #5128 failed 566ca87

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jamster10

…ld to be blank (elastic#117901) * Remove conditional preventing additional comment field to be blank * Remove tests for unwanted feature * Update server to prevent empty string comments * PR fix Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-11-22T22:23:25Z

💚 Backport successful

Status	Branch	Result
✅	8.0

This backport PR will be merged automatically after passing CI.

…ld to be blank (#117901) (#119396) * Remove conditional preventing additional comment field to be blank * Remove tests for unwanted feature * Update server to prevent empty string comments * PR fix Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kristof C <kpac.ja@gmail.com> Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co>

…ld to be blank (#117901) * Remove conditional preventing additional comment field to be blank * Remove tests for unwanted feature * Update server to prevent empty string comments * PR fix Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…ld to be blank (elastic#117901) * Remove conditional preventing additional comment field to be blank * Remove tests for unwanted feature * Update server to prevent empty string comments * PR fix Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

jamster10 added release_note:fix v8.0.0 Team:Threat Hunting Security Solution Threat Hunting Team auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:Threat Hunting:Cases v7.16.1 labels Nov 8, 2021

jamster10 self-assigned this Nov 8, 2021

jamster10 linked an issue Nov 8, 2021 that may be closed by this pull request

[Alerting] Unable to clear "Additional Comments" field in some connector tests #104961

Closed

jamster10 changed the title ~~Remove conditional preventing additional comment field to be blank~~ [Cases] [104961] Remove conditional preventing additional comment field to be blank Nov 8, 2021

Remove conditional preventing additional comment field to be blank

566ca87

jamster10 force-pushed the 104961-bug-unable-to-clear-additional-comments-field branch from 3a44c45 to 566ca87 Compare November 8, 2021 18:06

jamster10 requested review from stephmilovic and cnasikas November 8, 2021 18:07

jamster10 marked this pull request as ready for review November 8, 2021 18:08

jamster10 requested a review from a team as a code owner November 8, 2021 18:08

YulNaumenko approved these changes Nov 8, 2021

View reviewed changes

Remove tests for unwanted feature

537084c

Merge branch 'main' into 104961-bug-unable-to-clear-additional-commen…

5f26214

…ts-field

jamster10 enabled auto-merge (squash) November 16, 2021 17:54

jamster10 disabled auto-merge November 16, 2021 18:13

elastic deleted a comment from kibanamachine Nov 16, 2021

cnasikas reviewed Nov 18, 2021

View reviewed changes

cnasikas removed the v7.16.1 label Nov 18, 2021

Kristof-Pierre Cummings added 3 commits November 18, 2021 12:38

Merge branch 'main' into 104961-bug-unable-to-clear-additional-commen…

ded722d

…ts-field

Update server to prevent empty string comments

fc95640

Merge branch '104961-bug-unable-to-clear-additional-comments-field' o…

0bd73f6

…f github.com:jamster10/kibana into 104961-bug-unable-to-clear-additional-comments-field

cnasikas reviewed Nov 21, 2021

View reviewed changes

jonathan-buttner requested changes Nov 22, 2021

View reviewed changes

PR fix

81216bb

Merge branch 'main' into 104961-bug-unable-to-clear-additional-commen…

e55490e

…ts-field

jonathan-buttner approved these changes Nov 22, 2021

View reviewed changes

jamster10 merged commit 782f152 into elastic:main Nov 22, 2021

kibanamachine mentioned this pull request Nov 22, 2021

[8.0] [Cases] [104961] Remove conditional preventing additional comment field to be blank (#117901) #119396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] [104961] Remove conditional preventing additional comment field to be blank #117901

[Cases] [104961] Remove conditional preventing additional comment field to be blank #117901

jamster10 commented Nov 8, 2021 •

edited

Loading

elasticmachine commented Nov 8, 2021

elasticmachine commented Nov 8, 2021

YulNaumenko left a comment

jamster10 commented Nov 16, 2021

cnasikas left a comment •

edited

Loading

cnasikas Nov 21, 2021

jonathan-buttner Nov 22, 2021

jonathan-buttner Nov 22, 2021

jamster10 commented Nov 22, 2021

kibana-ci commented Nov 22, 2021

kibanamachine commented Nov 22, 2021

[Cases] [104961] Remove conditional preventing additional comment field to be blank #117901

[Cases] [104961] Remove conditional preventing additional comment field to be blank #117901

Conversation

jamster10 commented Nov 8, 2021 • edited Loading

Summary

Release notes

elasticmachine commented Nov 8, 2021

elasticmachine commented Nov 8, 2021

YulNaumenko left a comment

Choose a reason for hiding this comment

jamster10 commented Nov 16, 2021

cnasikas left a comment • edited Loading

Choose a reason for hiding this comment

cnasikas Nov 21, 2021

Choose a reason for hiding this comment

jonathan-buttner Nov 22, 2021

Choose a reason for hiding this comment

jonathan-buttner Nov 22, 2021

Choose a reason for hiding this comment

jamster10 commented Nov 22, 2021

kibana-ci commented Nov 22, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

kibanamachine commented Nov 22, 2021

💚 Backport successful

jamster10 commented Nov 8, 2021 •

edited

Loading

cnasikas left a comment •

edited

Loading