-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[npm] upgrade karma #11806
[npm] upgrade karma #11806
Conversation
Getting 3 failed tests locally
|
@tylersmalley dependably? I know the tag cloud tests have been somewhat flaky in the past, and they're passing here and on Jenkins |
@spalger, running again |
@thomasneirynck, are these tests a known issue? Or are they considered stable now? |
These tests pass locally for me if I use the |
It appears this is consistent with master and this PR does not seem to introduce any more failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 882079c)
(cherry picked from commit 882079c)
@tylersmalley Those tagcloud test failures in this PR are not a known issue right now. They were flaky about 6 months ago, but should have been resolved since (#9251). So if these failures are popping up again, we should investigate. Right now, Master, 5,x, 5.4 seem to be green though.. |
There have been a lot of chrome instances left running on Jenkins slaves, and based on the ps output they all seem to be instances started by karma. In an effort to fix that I realized our karma deps were pretty out of date.
For instance, after this test failure: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-intake/6921/
The box looked like this: