Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm] upgrade karma #11806

Merged
merged 1 commit into from
May 15, 2017
Merged

[npm] upgrade karma #11806

merged 1 commit into from
May 15, 2017

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 15, 2017

There have been a lot of chrome instances left running on Jenkins slaves, and based on the ps output they all seem to be instances started by karma. In an effort to fix that I realized our karma deps were pretty out of date.

For instance, after this test failure: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-intake/6921/

The box looked like this:
image

@tylersmalley
Copy link
Contributor

Getting 3 failed tests locallyChrome 58.0.3029 (Mac OS X 10.11.6): Executed 2950 of 2956 (3 FAILED) (skipped 6) (2 mins 47.749 secs / 31.792 secs)

Chrome 58.0.3029 (Mac OS X 10.11.6) tag cloud tests should only send single renderComplete event at the very end, using 500ms timeout positions should be ok FAILED
	TypeError: Cannot read property '1' of undefined
	    at shouldAssert (http://localhost:5610/bundles/tests.bundle.js:536089:28)
	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js:536103:13)
	    at <anonymous>
Chrome 58.0.3029 (Mac OS X 10.11.6) tag cloud tests should not get multiple render-events "before each" hook for "positions should be ok" FAILED
	Error: the string "Should not get multiple render events" was thrown, throw an Error :)
	    at <anonymous>

@spalger
Copy link
Contributor Author

spalger commented May 15, 2017

@tylersmalley dependably? I know the tag cloud tests have been somewhat flaky in the past, and they're passing here and on Jenkins

@tylersmalley
Copy link
Contributor

@spalger, running again

@tylersmalley
Copy link
Contributor

@thomasneirynck, are these tests a known issue? Or are they considered stable now?

@tylersmalley
Copy link
Contributor

These tests pass locally for me if I use the test:browser-ci task but I always get 3-4 failures when using test:browser. Seeing if this is also happening on master.

@tylersmalley
Copy link
Contributor

It appears this is consistent with master and this PR does not seem to introduce any more failures.

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 882079c into elastic:master May 15, 2017
spalger added a commit to spalger/kibana that referenced this pull request May 15, 2017
(cherry picked from commit 882079c)
spalger added a commit to spalger/kibana that referenced this pull request May 15, 2017
(cherry picked from commit 882079c)
@spalger spalger removed the v5.3.3 label May 15, 2017
@spalger
Copy link
Contributor Author

spalger commented May 15, 2017

5.5/5.x: 128be20
5.4: 154f52a

@thomasneirynck
Copy link
Contributor

thomasneirynck commented May 16, 2017

@tylersmalley Those tagcloud test failures in this PR are not a known issue right now. They were flaky about 6 months ago, but should have been resolved since (#9251). So if these failures are popping up again, we should investigate. Right now, Master, 5,x, 5.4 seem to be green though..

@spalger spalger deleted the upgrade/karma branch May 16, 2017 19:05
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants