Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Node Pipelines] Copy update for upload by csv error message #118611

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Nov 15, 2021

A small copy adjustment for single and plural errors per #101216 (comment)

@kgeller kgeller added release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management Feature:ECS Mapper labels Nov 15, 2021
@kgeller kgeller self-assigned this Nov 15, 2021
@kgeller kgeller requested a review from a team as a code owner November 15, 2021 19:42
@kgeller kgeller added the v8.1.0 label Nov 15, 2021
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @kgeller! I left just one small comment, let me know what you think 🚀

x-pack/plugins/ingest_pipelines/server/lib/mapper.ts Outdated Show resolved Hide resolved
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest changes LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kgeller

@kgeller kgeller merged commit 64379cd into elastic:main Nov 17, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 17, 2021
@kgeller kgeller deleted the ecs-mapper-copy-fix branch November 17, 2021 16:57
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ECS Mapper Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants