-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't enable RUM agent if APM is run with contextPropagationOnly #118685
Don't enable RUM agent if APM is run with contextPropagationOnly #118685
Conversation
@trentm in the long term, yes, we want. Right now, it's not a critical requirement. |
import { getConfiguration } from '@kbn/apm-config-loader'; | ||
|
||
function shouldInstrumentClient(config?: AgentConfigOptions): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this logic belongs to '@kbn/apm-config-loader'
. I left it here as it was implemented here before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, I don't think you should block on me. I don't have a feel for Kibana code structure at all.
I think having all logic for APM config in @kbn/apm-config-loader
might be less surprising.
Understood. Makes sense. |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…stic#118685) * do not enable RUM agent when nodejs is run in contextPropagationOnly mode * move shouldInstrumentClient to apm-config package
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…stic#118685) * do not enable RUM agent when nodejs is run in contextPropagationOnly mode * move shouldInstrumentClient to apm-config package
…stic#118685) * do not enable RUM agent when nodejs is run in contextPropagationOnly mode * move shouldInstrumentClient to apm-config package
…nly (elastic#118685) (elastic#118995)" This reverts commit ca86b98.
…8685) * do not enable RUM agent when nodejs is run in contextPropagationOnly mode * move shouldInstrumentClient to apm-config package
…stic#118685) * do not enable RUM agent when nodejs is run in contextPropagationOnly mode * move shouldInstrumentClient to apm-config package
…stic#118685) * do not enable RUM agent when nodejs is run in contextPropagationOnly mode * move shouldInstrumentClient to apm-config package
Summary
Follow up for #112973
APM RUM agent shouldn't send data to APM server if APM nodejs is run with contextPropagationOnly or
disableSend
flags (https://github.com/elastic/apm/blob/master/specs/agents/transport.md#disable_send-configuration).