Show long index pattern names in selector #11907
Conversation
|
This would be an improvement over the current situation, but it's not really a cure all. Very long index names will still get cut off (see screenshot below). That's probably less contrived than it sounds if we start allowing comma delimited index patterns. More importantly, we're using uiSelect in more than one place now and this only solves the issue in Discover. In other areas it may be less ridiculous to have longer values. I wouldn't be against merging this as a quick fix if a more universal solution is harder than it seems, but I don't think we should close the issue until we have a solution that works everywhere.
|
There was a problem hiding this comment.
LGTM. I agree with Matt's concerns about the use of this component elsewhere. I think the best solution might be to replace ui-select with our own React component. This would give us control over both the visual design and the behavior (e.g. how to handle long field values). We would then have the ability to evolve this component over time to meet new needs.
|
This change doesn't preclude making a larger fix as discussed in the other issues, it simply provides an extremely quick fix that addresses probably 95% of the problem discussed in the issue. It also fixes the problem without additionally requiring a hover pop-up which seems worse than just displaying the actual value, unless absolutely necessary. But that's just my opinion. 😄 |
Fixes #11870.
This PR simply adjusts the size of the index pattern selection choices to automatically scale based on the content rather than be a fixed width.