Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] timelion & vega apply dataview from first filter #119209

Merged
merged 4 commits into from
Nov 22, 2021
Merged

[Vega] timelion & vega apply dataview from first filter #119209

merged 4 commits into from
Nov 22, 2021

Conversation

drewdaemon
Copy link
Contributor

Summary

Fixes #56241

Applies the data view from the first filter for Elasticsearch requests from Vega and Timelion

Screen Shot 2021-11-19 at 11 49 28 AM

@drewdaemon drewdaemon requested a review from a team as a code owner November 19, 2021 17:55
@drewdaemon drewdaemon added Feature:Timelion Timelion app and visualization Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for both vega and TSVB and works as expected

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimelion 10.3KB 10.4KB +113.0B
visTypeVega 37.1KB 37.2KB +95.0B
total +208.0B
Unknown metric groups

References to deprecated APIs

id before after diff
visTypeVega 35 34 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp
alexwizp approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@drewdaemon drewdaemon merged commit 562384f into elastic:main Nov 22, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 22, 2021
@drewdaemon drewdaemon deleted the 56241/timelion-vega-support-nested-fields branch November 22, 2021 14:20
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@drewdaemon @dmlemeshko
[Vega] timelion & vega apply dataview from first filter (#119209)
5344e74
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@drewdaemon @TinLe
[Vega] timelion & vega apply dataview from first filter (elastic#119209)
eee8fa0
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@drewdaemon @gbamparop
[Vega] timelion & vega apply dataview from first filter (elastic#119209)
5529aac
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Timelion Timelion app and visualization Feature:Vega Vega visualizations release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timelion and Vega doesn't support filters with nested fields
6 participants
@drewdaemon @elasticmachine @flash1293 @kibana-ci @alexwizp @kibanamachine