Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Add loader for kibana overview while checking for user data view (#118881) #119221

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

pgayvallet
Copy link
Contributor

Backports the following commits to 8.0:

…stic#118881)

* add loader on overview page

* use KibanaThemeProvider for kibanaOverview

* change add data label to integrations

* adapt tests

* update snapshots, remove i18n keys

* review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@pgayvallet pgayvallet enabled auto-merge (squash) November 19, 2021 19:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaOverview 10.1KB 10.3KB +199.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 63.4KB 63.4KB +16.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 4bcecb6 into elastic:8.0 Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants