Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename auto create data view APM setting #120689

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Conversation

smith
Copy link
Contributor

@smith smith commented Dec 7, 2021

from xpack.apm.autocreateApmIndexPattern to xpack.apm.autoCreateApmDataView.

Note the capitalization change. It now is autoCreate instead of autocreate.

Fixes #120095.

from `xpack.apm.autocreateApmIndexPattern` to `xpack.apm.autoCreateApmDataView`.

Note the capitalization change. It now is `autoCreate` instead of `autocreate`.

Fixes elastic#120095.
@smith smith added release_note:deprecation v8.0.0 auto-backport Deprecated: Automatically backport this PR after it's merged labels Dec 7, 2021
@smith smith requested a review from a team as a code owner December 7, 2021 21:43
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 27bbd3d into elastic:main Dec 8, 2021
@smith smith deleted the nls/data-view-rename branch December 8, 2021 03:33
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2021
from `xpack.apm.autocreateApmIndexPattern` to `xpack.apm.autoCreateApmDataView`.

Note the capitalization change. It now is `autoCreate` instead of `autocreate`.

Fixes elastic#120095.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 8, 2021
from `xpack.apm.autocreateApmIndexPattern` to `xpack.apm.autoCreateApmDataView`.

Note the capitalization change. It now is `autoCreate` instead of `autocreate`.

Fixes #120095.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
from `xpack.apm.autocreateApmIndexPattern` to `xpack.apm.autoCreateApmDataView`.

Note the capitalization change. It now is `autoCreate` instead of `autocreate`.

Fixes elastic#120095.
@MiriamAparicio MiriamAparicio self-assigned this Dec 22, 2021
@MiriamAparicio MiriamAparicio added the apm:test-plan-done Pull request that was successfully tested during the test plan label Dec 22, 2021
@MiriamAparicio MiriamAparicio removed their assignment Dec 22, 2021
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
from `xpack.apm.autocreateApmIndexPattern` to `xpack.apm.autoCreateApmDataView`.

Note the capitalization change. It now is `autoCreate` instead of `autocreate`.

Fixes elastic#120095.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-8.0.0 apm:test-plan-done Pull request that was successfully tested during the test plan auto-backport Deprecated: Automatically backport this PR after it's merged release_note:deprecation Team:APM All issues that need APM UI Team support v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Rename xpack.apm.autocreateApmIndexPattern to xpack.apm.autocreateApmDataView
7 participants