-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] fix vector tile double counting geo_shapes that cross tile boundaries #121703
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
This is a technical limitation because there are no identifiers for vector tile features, or it would be too expensive to detect unique features, right? Just curious. Showing a feature count is very useful information, so I would not want to remove that info from our users, but on the other hand, the explanation may be confusing for users not familiarized with webmapping regarding tiles. Maybe we can find a different way to communicate this by simplifying the tooltip message, and maybe pointing users to a more detailed explanation in our docs? (no idea how to do this in a tooltip) We can also go forward with this proposal and wait for more feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Suggestion for other wording, but imho, it's already much an improvement. And we can always revise based on outside input.
x-pack/plugins/maps/public/classes/layers/vector_layer/mvt_vector_layer/mvt_vector_layer.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…ndaries (elastic#121703) * [Maps] fix vector tile double counting geo_shapes that cross tile boundaries * only show messages when multiple tiles contain features * eslint * clean up message * cleanuyp * review feedback * eslint * update expect statement Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #121564
Since there is no way to know which features cross tile boundaries, the only thing to do is provide context for the count value and let users know documents my be counted multiple times.
In the image below, there are only 250 documents in the index so the count of 281 contains some documents that are counted multiple times.