Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix vector tile double counting geo_shapes that cross tile boundaries #121703

Merged
merged 9 commits into from
Dec 23, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 20, 2021

Fixes #121564

Since there is no way to know which features cross tile boundaries, the only thing to do is provide context for the count value and let users know documents my be counted multiple times.

In the image below, there are only 250 documents in the index so the count of 281 contains some documents that are counted multiple times.

Screen Shot 2021-12-20 at 3 41 44 PM

@nreese nreese marked this pull request as ready for review December 20, 2021 22:43
@nreese nreese requested a review from a team as a code owner December 20, 2021 22:43
@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.1.0 labels Dec 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese added the backport:skip This commit does not require backporting label Dec 20, 2021
@jsanz
Copy link
Member

jsanz commented Dec 21, 2021

Since there is no way to know which features cross tile boundaries,

This is a technical limitation because there are no identifiers for vector tile features, or it would be too expensive to detect unique features, right? Just curious.

Showing a feature count is very useful information, so I would not want to remove that info from our users, but on the other hand, the explanation may be confusing for users not familiarized with webmapping regarding tiles. Maybe we can find a different way to communicate this by simplifying the tooltip message, and maybe pointing users to a more detailed explanation in our docs? (no idea how to do this in a tooltip)

We can also go forward with this proposal and wait for more feedback.

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Suggestion for other wording, but imho, it's already much an improvement. And we can always revise based on outside input.

@nreese
Copy link
Contributor Author

nreese commented Dec 22, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +239.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 0abd51e into elastic:main Dec 23, 2021
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
…ndaries (elastic#121703)

* [Maps] fix vector tile double counting geo_shapes that cross tile boundaries

* only show messages when multiple tiles contain features

* eslint

* clean up message

* cleanuyp

* review feedback

* eslint

* update expect statement

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[maps] vector tile double counting geo_shapes that cross tile boundaries
6 participants