Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable URL drilldown for all dashboard panels #121801

Merged
merged 8 commits into from
Dec 30, 2021

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Dec 21, 2021

Summary

Closes #111893

This change enables context menu URL drill-down for all Dashboard panels.

This PR also now always shows the <TriggerPicker>, even if there is only a single trigger to pick from, the single trigger is pre-selected and remains always selected.

This makes it clear to what trigger URL drilldown is being attached:

image

Trigger picker now always visible in dashboard drilldown setup:

image

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

Release note

URL Drilldown can now be added to any Dashboard panel.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
note: I think we need only the v8.1.0 version label on this pr. No need for v8.2.0

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the code changes and tested locally in chrome. I validated that with this PR URL Drilldowns via the action menu are available on saved searches and Lens metric panels.

LGTM!

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 14.2KB 14.2KB +31.0B
uiActionsEnhanced 22.0KB 22.1KB +161.0B
total +192.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 30, 2021
@vadimkibana vadimkibana merged commit 828321c into elastic:main Dec 30, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 30, 2021
@vadimkibana vadimkibana deleted the fix-ctx-drill-2 branch December 30, 2021 11:11
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 121801

gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
* enable drilldowns for all panels

* update test

* add context menu trigger to all triggers

* filter out factories with premium license

* filter action factories according to triggers

* fix test

* always show trigger picker

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting Feature:Drilldowns Embeddable panel Drilldowns release_note:enhancement v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support context menu trigger drilldowns for all panels
6 participants