-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable URL drilldown for all dashboard panels #121801
Conversation
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
note: I think we need only the v8.1.0
version label on this pr. No need for v8.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the code changes and tested locally in chrome. I validated that with this PR URL Drilldowns via the action menu are available on saved searches and Lens metric panels.
LGTM!
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failedThe backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
* enable drilldowns for all panels * update test * add context menu trigger to all triggers * filter out factories with premium license * filter action factories according to triggers * fix test * always show trigger picker Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #111893
This change enables context menu URL drill-down for all Dashboard panels.
This PR also now always shows the
<TriggerPicker>
, even if there is only a single trigger to pick from, the single trigger is pre-selected and remains always selected.This makes it clear to what trigger URL drilldown is being attached:
Trigger picker now always visible in dashboard drilldown setup:
Checklist
Delete any items that are not applicable to this PR.
Release note
URL Drilldown can now be added to any Dashboard panel.