[Console] Configure refresh frequency #121874

mibragimov · 2021-12-22T12:29:09Z

Closes #119218

Kuznietsov

@mibragimov, thanks for your efforts 👍

It has left some minor changes to be done. I'm sure, you'll fix that very quickly )

src/plugins/console/public/application/components/refresh_interval.tsx

src/plugins/console/public/application/components/settings_modal.tsx

src/plugins/console/public/application/components/refresh_interval.tsx

src/plugins/console/public/services/settings.ts

src/plugins/console/public/application/components/refresh_interval.tsx

sabarasaba

Left some initial feedback for now, lets keep the conversation going and we can do a full review after we are all happy with the approach to take 🚀

src/plugins/console/public/application/components/refresh_interval.tsx

src/plugins/console/public/services/settings.ts

sabarasaba

Thank for patching this up @mibragimov! Latest changes lgtm, left one small nit that I think could simplify the code a little bit but its a non-blocker 🚀

PS: Could we also update the screenshot of the PR?

sabarasaba · 2021-12-27T16:01:28Z

src/plugins/console/public/application/components/settings_modal.tsx


 export type AutocompleteOptions = 'fields' | 'indices' | 'templates';

+const MILLISECONDS_IN_MINUTE = 60000;


nit: what do you think about replacing these constants and the intervalOptions definition with something more compact that uses pluralization:

const PRESETS_IN_MINUTES = [1, 5, 10]; const intervalOptions = PRESETS_IN_MINUTES.map(value => ({ value: value * 60000, text: i18n.translate('console.settingsPage.refreshInterval.timeInterval', { defaultMessage: '{value} {value, plural, one {minute} other {minutes}}', values: { value }, }), }));

alexwizp · 2021-12-27T20:06:54Z

src/plugins/console/public/application/components/settings_modal.tsx

+                compressed
+                options={intervalOptions}
+                value={pollInterval}
+                onChange={(e) => {


please try to use useCallback hook to avoid extra rerenderings 🙏

elasticmachine · 2021-12-28T10:13:42Z

Pinging @elastic/kibana-stack-management (Team:Stack Management)

mibragimov · 2021-12-28T10:14:37Z

@elasticmachine merge upstream

kibana-ci · 2021-12-28T11:35:34Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`console`	376.2KB	377.0KB	+780.0B

History

💚 Build #15069 succeeded 1634ba9
💚 Build #14971 succeeded 4b0372d
💔 Build #14784 failed a3204ae

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mibragimov

Kuznietsov

Code LGTM 🚀

Kuznietsov · 2021-12-28T12:20:56Z

src/plugins/console/public/services/settings.ts

@@ -87,13 +89,22 @@ export class Settings {
    return this.storage.get('disable_history', DEFAULT_SETTINGS.historyDisabled);
  }

+  setPollInterval(interval: number) {
+    this.storage.set('poll_interval', interval);


Nit: it would be a great idea to move these identificators ( 'poll_interval', for example) to the constant variables. What do you think about it?

cjcenizal · 2021-12-28T16:51:59Z

@mibragimov Regarding this point from #119218:

Request once on load, but disable polling

This is actually a separate feature from the user-specified poll frequency. The idea was to provide the user with a toggle that, when enabled, would cause Console to only request the mappings, aliases, and templates when it's loaded, instead of on an interval. Does that make sense?

mibragimov · 2021-12-29T11:45:22Z

@mibragimov Regarding this point from #119218:

Request once on load, but disable polling

This is actually a separate feature from the user-specified poll frequency. The idea was to provide the user with a toggle that, when enabled, would cause Console to only request the mappings, aliases, and templates when it's loaded, instead of on an interval. Does that make sense?

Got it. I created a separate PR for this feature #122125

* Add configurable poll interval Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Add configurable poll interval

a3204ae

mibragimov added release_note:enhancement Feature:Console Dev Tools Console Feature Feature:Dev Tools backport:skip This commit does not require backporting v8.1.0 labels Dec 22, 2021

mibragimov requested review from alexwizp, Kuznietsov and vladpro25 December 22, 2021 12:29

mibragimov self-assigned this Dec 22, 2021

lint

4b0372d

Kuznietsov suggested changes Dec 23, 2021

View reviewed changes

Kuznietsov added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Dec 24, 2021

mibragimov requested a review from sabarasaba December 24, 2021 09:30

sabarasaba reviewed Dec 24, 2021

View reviewed changes

src/plugins/console/public/application/components/refresh_interval.tsx Outdated Show resolved Hide resolved

src/plugins/console/public/services/settings.ts Outdated Show resolved Hide resolved

Replace EuiRefreshInterval component

1634ba9

Kuznietsov self-requested a review December 24, 2021 16:46

sabarasaba approved these changes Dec 27, 2021

View reviewed changes

alexwizp reviewed Dec 27, 2021

View reviewed changes

Address comments

b4f0189

mibragimov marked this pull request as ready for review December 28, 2021 10:13

mibragimov requested a review from a team as a code owner December 28, 2021 10:13

Merge branch 'main' into polling

d3a95d8

Kuznietsov approved these changes Dec 28, 2021

View reviewed changes

alexwizp approved these changes Dec 29, 2021

View reviewed changes

mibragimov merged commit b714f41 into elastic:main Dec 29, 2021

mibragimov deleted the polling branch December 29, 2021 11:45

cjcenizal mentioned this pull request Dec 29, 2021

[Console] Refresh frequency refinements #122125

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Console] Configure refresh frequency #121874

[Console] Configure refresh frequency #121874

mibragimov commented Dec 22, 2021 •

edited

Loading

Kuznietsov left a comment

sabarasaba left a comment

sabarasaba left a comment •

edited

Loading

sabarasaba Dec 27, 2021

alexwizp Dec 27, 2021

elasticmachine commented Dec 28, 2021

mibragimov commented Dec 28, 2021

kibana-ci commented Dec 28, 2021

Kuznietsov left a comment

Kuznietsov Dec 28, 2021

cjcenizal commented Dec 28, 2021 •

edited

Loading

mibragimov commented Dec 29, 2021


		export type AutocompleteOptions = 'fields' \| 'indices' \| 'templates';

		const MILLISECONDS_IN_MINUTE = 60000;

[Console] Configure refresh frequency #121874

[Console] Configure refresh frequency #121874

Conversation

mibragimov commented Dec 22, 2021 • edited Loading

Kuznietsov left a comment

Choose a reason for hiding this comment

sabarasaba left a comment

Choose a reason for hiding this comment

sabarasaba left a comment • edited Loading

Choose a reason for hiding this comment

sabarasaba Dec 27, 2021

Choose a reason for hiding this comment

alexwizp Dec 27, 2021

Choose a reason for hiding this comment

elasticmachine commented Dec 28, 2021

mibragimov commented Dec 28, 2021

kibana-ci commented Dec 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Kuznietsov left a comment

Choose a reason for hiding this comment

Kuznietsov Dec 28, 2021

Choose a reason for hiding this comment

cjcenizal commented Dec 28, 2021 • edited Loading

mibragimov commented Dec 29, 2021

mibragimov commented Dec 22, 2021 •

edited

Loading

sabarasaba left a comment •

edited

Loading

cjcenizal commented Dec 28, 2021 •

edited

Loading