Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] change "show as" from EuiSelect to EuiButtonGroup #121960

Merged
merged 5 commits into from
Jan 25, 2022
Merged

[Maps] change "show as" from EuiSelect to EuiButtonGroup #121960

merged 5 commits into from
Jan 25, 2022

Conversation

maksimkovalev
Copy link
Contributor

Closes: #121897

This PR contains changes for the "Clusters and grids" feature.
Users will now be able to see all the viewing options and select it from a group of buttons, rather than from a drop-down list as before.

How it will looks like:
Screenshot 2021-12-23 at 16 23 20

cc @nreese

@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 23, 2021 •
edited
Loading

💚 CLA has been signed

@thomasneirynck thomasneirynck added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.1.0 release_note:enhancement labels Dec 27, 2021
thomasneirynck
thomasneirynck approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx looks a lot more clean!

A few nits. Mainly, I would not use this PR to introduce hooks. Hooks are a form of meta-programming, adding more overhead. When they are consistently used, they might provide an overall benefit, but since the maps plugin does not use them right now, and since their use here is not saving any LOC here, I wouldn't make this refactor.

x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/render_as_select.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/render_as_select.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/render_as_select.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/render_as_select.tsx Outdated Show resolved Hide resolved
nreese
nreese approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review, tested in chrome

@thomasneirynck thomasneirynck marked this pull request as ready for review January 10, 2022 15:53
@thomasneirynck thomasneirynck requested a review from a team as a code owner January 10, 2022 15:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor

@elasticmachine merge upstream

@thomasneirynck
Copy link
Contributor

buildkite test this

@maksimkovalev
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB +141.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit aaf1621 into elastic:main Jan 25, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maps] change "show as" from EuiSelect to EuiButtonGroup
6 participants
@maksimkovalev @kibanamachine @elasticmachine @thomasneirynck @kibana-ci @nreese