Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Coloring tooltips in Pie are not properly positioned #123042

Closed
wants to merge 3 commits into from
Closed

[Visualize] Coloring tooltips in Pie are not properly positioned #123042

wants to merge 3 commits into from

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Jan 14, 2022 •
edited
Loading

Closes #116748

Summary

Replaced EuiPopover and wrapping EuiOutsideClickDetector with EuiWrappingPopover component to fix positioning of coloring tooltip

pie color picker tooltip

For maintainers

@DianaDerevyankina DianaDerevyankina self-assigned this Jan 14, 2022
@DianaDerevyankina DianaDerevyankina added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Jan 17, 2022
alexwizp
alexwizp approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thank you

@stratoula stratoula added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Jan 17, 2022
@DianaDerevyankina DianaDerevyankina marked this pull request as ready for review January 17, 2022 14:48
@DianaDerevyankina DianaDerevyankina requested a review from a team as a code owner January 17, 2022 14:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

@stratoula stratoula added v8.1.0 Feature:Pie Chart Pie chart visualization feature labels Jan 17, 2022
stratoula
stratoula reviewed Jan 17, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The popover position works fine when I click it. I tested in both Chrome and Safari but it doesnt work always correctly.

image

Click to overwrite a color, move right or left with the keyboard arrows. Check the popover. It is moved on the top left

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPie 39.6KB 39.5KB -108.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@mbondyra mbondyra mentioned this pull request Feb 2, 2022
Merged
@stratoula
Copy link
Contributor

Closing this in favor of #124330

@stratoula stratoula closed this Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula left review comments

@alexwizp alexwizp alexwizp approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
Feature:Pie Chart Pie chart visualization feature release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Visualize] Coloring tooltips in Pie are not properly positioned
6 participants
@DianaDerevyankina @elasticmachine @stratoula @alexwizp @kibana-ci @kibanamachine