-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualize] Coloring tooltips in Pie are not properly positioned #124330
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Yes @mbondyra! Diana's PR can close in favor of this one. I am closing this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome and Safari and works fine! I am just curious about the initial cause :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested that and works fine! 🎉 Code LGTM
Also am fine with this change thanks @nickofthyme. The EuiPopover should better handle the focus management of the color icon vs sending it back to window. Thank you for implementing this 💪🏻 |
Closes: #116748
Summary
Steps to reproduce:
Screen:
Screen.Recording.2022-02-02.at.12.44.51.PM.mov
What was changed:
EuiPopover
->EuiWrappingPopover
LegendColorPickerWrapperContext
context. This context is used instead of useMemo patterrnuseMemo
forgetColorPicker
was removed;Related to elastic/eui#4367