-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualize] Make sure session is updated and passed to the embeddable #123538
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, Refresh works fine now. I did many tests and I can't find any regression.
@alexwizp do you want to also take a look?
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Fixes #121791
Updating the session from the top nav would not trigger a reload because the input of the embeddable handler (which is used in the editor as well) is not updated. This was also the case for time range changes - the vis refreshed in these cases because the time range changed, but it wouldn't start a new session for this so everything would go into the same session. This shouldn't happen - on every change in filters/query/timerange a new session is required.
This PR changes the following:
reloadVisualization
so it is recognizing something changed even if it's just the sessionreloadVisualization
), update the embeddable handler inputThis has to be reviewed carefully from someone knowing their way around visualize.